Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Hashes API support #282

Merged
merged 35 commits into from
Jul 4, 2022
Merged

Remove Hashes API support #282

merged 35 commits into from
Jul 4, 2022

Conversation

gudmdharalds
Copy link
Contributor

@gudmdharalds gudmdharalds commented Jun 27, 2022

This pull request removes the Hashes API support from vip-go-ci.

TODO:

  • Remove relevant code which implements Hashes API support:
    • ap-hashes-api.php
    • auto-approval.php
    • defines.php
    • log.php
    • main.php
    • reports.php
    • requires.php
    • statistics.php
  • Update tests and remove references to Hashes API
    • tests/integration/ApAutoApprovalTest.php
      • Rename and apply WP CS.
    • tests/integration/ApHashesApiFileApprovedTest.php
    • tests/integration/ApHashesApiScanCommitTest.php
    • tests/integration/MiscApprovedFilesCommentsRemoveTest.php
    • tests/unit/MainRunInitOptionsAutoapproveHashesOverlapTest.php
    • tests/unit/MainRunInitOptionsHashesOptionsTest.php
    • tests/unit/OptionsReadRepositoryConfigFileTest.php
    • tests/unit/ReportCreateScanDetailsAutoApproveConfigurationTest.php
    • tests/unit/ResultsFilterIgnorableTest.php
    • tests/unit/SkipFileTestFunctionality.php
    • tests/unit/StatsStatsInitTest.php
    • unittests.ini.dist
  • Update README file
  • Check status of automated tests
  • Changelog entry (for VIP) [ Changelog for version 1.2.4 #275 ]

@gudmdharalds gudmdharalds added this to the 1.2.4 milestone Jun 27, 2022
@gudmdharalds gudmdharalds self-assigned this Jun 27, 2022
@gudmdharalds gudmdharalds changed the title Remove Hashes API support. Remove Hashes API support Jun 27, 2022
@gudmdharalds gudmdharalds marked this pull request as ready for review July 4, 2022 14:30
@wpcomvip-vipgoci-bot
Copy link
Collaborator

No issues were found to report when scanning latest commit (commit-ID: 66eeedd)


This bot provides automated PHP linting and PHPCS scanning. For more information about the bot and available customizations, see our documentation.



Scan run detail

Software versions

  • vip-go-ci version: 1.2.3
  • PHP runtime version for vip-go-ci: 8.1.7
  • PHP runtime for linting:
    • PHP 8.1: 8.1.7
  • PHP runtime version for PHPCS: 7.4.30
  • PHPCS version: 3.6.2
  • PHP runtime version for SVG scanner: 7.4.30

Options file (.vipgoci_options)

Options file enabled: true

Configurable options:

  • skip-execution
  • skip-draft-prs
  • lint-modified-files-only
  • phpcs
  • phpcs-severity
  • phpcs-sniffs-include
  • phpcs-sniffs-exclude
  • report-no-issues-found
  • review-comments-sort
  • review-comments-include-severity
  • post-generic-pr-support-comments
  • review-comments-sort
  • scan-details-msg-include
  • svg-checks
  • autoapprove
  • autoapprove-php-nonfunctional-changes
  • hashes-api

Options altered:

  • phpcs-severityset to1
  • phpcs-sniffs-includeset toGeneric.PHP.DisallowShortOpenTag, Squiz.PHP.CommentedOutCode
  • phpcs-sniffs-excludeset toWordPress.Security.EscapeOutput, WordPress.PHP.DevelopmentFunctions, WordPress.WP.AlternativeFunctions, WordPress.PHP.DiscouragedPHPFunctions, WordPress.Files.FileName, Squiz.Commenting.FileComment, Generic.PHP.Syntax
  • skip-draft-prsset to

PHP lint options

PHP lint files enabled: true

Lint modified files only: true

Directories not PHP linted:

  • None

SVG configuration

SVG scanning enabled: true

Auto-approval configuration

Auto-approvals enabled: true

Non-functional changes auto-approved: true

Auto-approval DB enabled: false

Auto-approved file-types:

  • css
  • csv
  • eot
  • gif
  • gz
  • ico
  • ini
  • jpeg
  • jpg
  • json
  • less
  • map
  • md
  • mdown
  • mo
  • mp4
  • otf
  • pcss
  • pdf
  • po
  • pot
  • png
  • sass
  • scss
  • styl
  • ttf
  • txt
  • woff
  • woff2
  • yml

PHPCS configuration

PHPCS scanning enabled: true

PHPCS severity level: 1

Standard(s) used:

  • PHPCompatibility
  • PHPCompatibilityParagonieRandomCompat
  • PHPCompatibilityParagonieSodiumCompat
  • VariableAnalysis
  • WordPress

Runtime set:

  • testVersion 8.1-

Custom sniffs included:

  • Generic.PHP.DisallowShortOpenTag
  • Squiz.PHP.CommentedOutCode

Custom sniffs excluded:

  • WordPress.Security.EscapeOutput
  • WordPress.PHP.DevelopmentFunctions
  • WordPress.WP.AlternativeFunctions
  • WordPress.PHP.DiscouragedPHPFunctions
  • WordPress.Files.FileName
  • Squiz.Commenting.FileComment
  • Generic.PHP.Syntax

Directories not PHPCS scanned:

  • tests/unit

@gudmdharalds gudmdharalds merged commit 1a0648d into trunk Jul 4, 2022
@gudmdharalds gudmdharalds deleted the remove/hashes-api branch July 4, 2022 14:58
@gudmdharalds gudmdharalds mentioned this pull request Oct 6, 2022
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants