PHP lint using multiple PHP versions #255

gudmdharalds · 2022-03-02T15:31:07Z

We need to PHP lint using multiple PHP versions and collect the results from all of these. Multiple PHP interpreters should be configurable on the command line.

TODO:

wpcomvip-vipgoci-bot

phpcs scanning turned up:

⚠️ 1 warning

This bot provides automated PHP linting and PHPCS scanning. For more information about the bot and available customizations, see our documentation.

Scan run detail

Software versions vip-go-ci version: `1.2.0` PHP runtime version for vip-go-ci: `8.1.3` PHP runtime version for PHP linting: `8.1.3` PHP runtime version for PHPCS: `7.4.28` PHPCS version: `3.6.2` Options file (`.vipgoci_options`) Options file enabled: `true` Configurable options: `skip-execution` `skip-draft-prs` `lint-modified-files-only` `phpcs` `phpcs-severity` `phpcs-sniffs-include` `phpcs-sniffs-exclude` `report-no-issues-found` `review-comments-sort` `review-comments-include-severity` `post-generic-pr-support-comments` `review-comments-sort` `scan-details-msg-include` `svg-checks` `autoapprove` `autoapprove-php-nonfunctional-changes` `hashes-api` Options altered: `phpcs-severity`set to`1` `phpcs-sniffs-include`set to`Generic.PHP.DisallowShortOpenTag, Squiz.PHP.CommentedOutCode` `phpcs-sniffs-exclude`set to`WordPress.Security.EscapeOutput, WordPress.PHP.DevelopmentFunctions, WordPress.WP.AlternativeFunctions, WordPress.PHP.DiscouragedPHPFunctions, WordPress.Files.FileName, Squiz.Commenting.FileComment, Generic.PHP.Syntax` `skip-draft-prs`set to	PHP lint options PHP lint files enabled: `true` Lint modified files only: `true` Directories not PHP linted: None SVG configuration SVG scanning enabled: `true` Auto-approval configuration Auto-approvals enabled: `true` Non-functional changes auto-approved: `true` Auto-approval DB enabled: `true` Auto-approved file-types: `css` `csv` `eot` `gif` `gz` `ico` `ini` `jpeg` `jpg` `json` `less` `map` `md` `mdown` `mo` `mp4` `otf` `pcss` `pdf` `po` `pot` `png` `sass` `scss` `styl` `ttf` `txt` `woff` `woff2` `yml`	PHPCS configuration PHPCS scanning enabled: `true` PHPCS severity level: `1` Standard(s) used: `PHPCompatibility` `PHPCompatibilityParagonieRandomCompat` `PHPCompatibilityParagonieSodiumCompat` `VariableAnalysis` `WordPress` Runtime set: `testVersion 8.1-` Custom sniffs included: `Generic.PHP.DisallowShortOpenTag` `Squiz.PHP.CommentedOutCode` Custom sniffs excluded: `WordPress.Security.EscapeOutput` `WordPress.PHP.DevelopmentFunctions` `WordPress.WP.AlternativeFunctions` `WordPress.PHP.DiscouragedPHPFunctions` `WordPress.Files.FileName` `Squiz.Commenting.FileComment` `Generic.PHP.Syntax` Directories not PHPCS scanned: `tests/unit`

lint-scan.php

… be scanned.

…ath used.

wpcomvip-vipgoci-bot

phpcs scanning turned up:

⚠️ 11 warnings

This bot provides automated PHP linting and PHPCS scanning. For more information about the bot and available customizations, see our documentation.

Scan run detail

Software versions vip-go-ci version: `1.2.0` PHP runtime version for vip-go-ci: `8.1.3` PHP runtime version for PHP linting: `8.1.3` PHP runtime version for PHPCS: `7.4.28` PHPCS version: `3.6.2` Options file (`.vipgoci_options`) Options file enabled: `true` Configurable options: `skip-execution` `skip-draft-prs` `lint-modified-files-only` `phpcs` `phpcs-severity` `phpcs-sniffs-include` `phpcs-sniffs-exclude` `report-no-issues-found` `review-comments-sort` `review-comments-include-severity` `post-generic-pr-support-comments` `review-comments-sort` `scan-details-msg-include` `svg-checks` `autoapprove` `autoapprove-php-nonfunctional-changes` `hashes-api` Options altered: `phpcs-severity`set to`1` `phpcs-sniffs-include`set to`Generic.PHP.DisallowShortOpenTag, Squiz.PHP.CommentedOutCode` `phpcs-sniffs-exclude`set to`WordPress.Security.EscapeOutput, WordPress.PHP.DevelopmentFunctions, WordPress.WP.AlternativeFunctions, WordPress.PHP.DiscouragedPHPFunctions, WordPress.Files.FileName, Squiz.Commenting.FileComment, Generic.PHP.Syntax` `skip-draft-prs`set to	PHP lint options PHP lint files enabled: `true` Lint modified files only: `true` Directories not PHP linted: None SVG configuration SVG scanning enabled: `true` Auto-approval configuration Auto-approvals enabled: `true` Non-functional changes auto-approved: `true` Auto-approval DB enabled: `true` Auto-approved file-types: `css` `csv` `eot` `gif` `gz` `ico` `ini` `jpeg` `jpg` `json` `less` `map` `md` `mdown` `mo` `mp4` `otf` `pcss` `pdf` `po` `pot` `png` `sass` `scss` `styl` `ttf` `txt` `woff` `woff2` `yml`	PHPCS configuration PHPCS scanning enabled: `true` PHPCS severity level: `1` Standard(s) used: `PHPCompatibility` `PHPCompatibilityParagonieRandomCompat` `PHPCompatibilityParagonieSodiumCompat` `VariableAnalysis` `WordPress` Runtime set: `testVersion 8.1-` Custom sniffs included: `Generic.PHP.DisallowShortOpenTag` `Squiz.PHP.CommentedOutCode` Custom sniffs excluded: `WordPress.Security.EscapeOutput` `WordPress.PHP.DevelopmentFunctions` `WordPress.WP.AlternativeFunctions` `WordPress.PHP.DiscouragedPHPFunctions` `WordPress.Files.FileName` `Squiz.Commenting.FileComment` `Generic.PHP.Syntax` Directories not PHPCS scanned: `tests/unit`

tests/integration/helper/LintScanMultipleFiles.php

wpcomvip-vipgoci-bot · 2022-03-07T13:20:13Z

Scanning latest commit did not yield any new issues. Please have a look at older feedback still existing (commit-ID: e060179)

This bot provides automated PHP linting and PHPCS scanning. For more information about the bot and available customizations, see our documentation.

Scan run detail

Software versions vip-go-ci version: `1.2.0` PHP runtime version for vip-go-ci: `8.1.3` PHP runtime version for PHP linting: `8.1.3` PHP runtime version for PHPCS: `7.4.28` PHPCS version: `3.6.2` Options file (`.vipgoci_options`) Options file enabled: `true` Configurable options: `skip-execution` `skip-draft-prs` `lint-modified-files-only` `phpcs` `phpcs-severity` `phpcs-sniffs-include` `phpcs-sniffs-exclude` `report-no-issues-found` `review-comments-sort` `review-comments-include-severity` `post-generic-pr-support-comments` `review-comments-sort` `scan-details-msg-include` `svg-checks` `autoapprove` `autoapprove-php-nonfunctional-changes` `hashes-api` Options altered: `phpcs-severity`set to`1` `phpcs-sniffs-include`set to`Generic.PHP.DisallowShortOpenTag, Squiz.PHP.CommentedOutCode` `phpcs-sniffs-exclude`set to`WordPress.Security.EscapeOutput, WordPress.PHP.DevelopmentFunctions, WordPress.WP.AlternativeFunctions, WordPress.PHP.DiscouragedPHPFunctions, WordPress.Files.FileName, Squiz.Commenting.FileComment, Generic.PHP.Syntax` `skip-draft-prs`set to	PHP lint options PHP lint files enabled: `true` Lint modified files only: `true` Directories not PHP linted: None SVG configuration SVG scanning enabled: `true` Auto-approval configuration Auto-approvals enabled: `true` Non-functional changes auto-approved: `true` Auto-approval DB enabled: `true` Auto-approved file-types: `css` `csv` `eot` `gif` `gz` `ico` `ini` `jpeg` `jpg` `json` `less` `map` `md` `mdown` `mo` `mp4` `otf` `pcss` `pdf` `po` `pot` `png` `sass` `scss` `styl` `ttf` `txt` `woff` `woff2` `yml`	PHPCS configuration PHPCS scanning enabled: `true` PHPCS severity level: `1` Standard(s) used: `PHPCompatibility` `PHPCompatibilityParagonieRandomCompat` `PHPCompatibilityParagonieSodiumCompat` `VariableAnalysis` `WordPress` Runtime set: `testVersion 8.1-` Custom sniffs included: `Generic.PHP.DisallowShortOpenTag` `Squiz.PHP.CommentedOutCode` Custom sniffs excluded: `WordPress.Security.EscapeOutput` `WordPress.PHP.DevelopmentFunctions` `WordPress.WP.AlternativeFunctions` `WordPress.PHP.DiscouragedPHPFunctions` `WordPress.Files.FileName` `Squiz.Commenting.FileComment` `Generic.PHP.Syntax` Directories not PHPCS scanned: `tests/unit`

gudmdharalds added 8 commits March 2, 2022 14:13

Rename test.

93e8609

Transforming test into unit-test.

8dc850b

Test was renamed and transformed to unit-test.

adedb56

Update test, apply WP CS.

47a01bc

Test was renamed.

8ce9547

Renaming test class.

cf345e7

Applying WP CS, adjusting test.

3b070c9

Test was renamed.

0fa2c45

gudmdharalds added the [Type] Enhancement label Mar 2, 2022

gudmdharalds added this to the 1.2.0 milestone Mar 2, 2022

gudmdharalds self-assigned this Mar 2, 2022

gudmdharalds modified the milestones: 1.2.0, 1.2.1 Mar 2, 2022

gudmdharalds mentioned this pull request Mar 2, 2022

Clean up test suites #244

Open

54 tasks

gudmdharalds and others added 6 commits March 2, 2022 15:45

Update @Covers.

6a267e6

Report all PHP interpreter versions.

078af70

vipgoci_util_php_interpreter_get_version(): Cache results, use trim().

7624237

Implementing multi PHP version linting.

0b2498e

Add support for linting using multiple PHP versions.

33943e1

Merge branch 'main' into lint-multi-version

3d4d891

wpcomvip-vipgoci-bot reviewed Mar 2, 2022

View reviewed changes

lint-scan.php Outdated Show resolved Hide resolved

gudmdharalds added 9 commits March 2, 2022 22:52

Rename test class.

743e077

Update example output.

3e4d37b

Adding defines for error message when PHP linting fails.

7948067

Update --help message & comment, remove failure message on start up.

9371fc2

Escape output, catch when PHP linting fails and notify users.

d6174b4

Remove white spacing in string.

284e40f

Detect if shell returns with a file not found error.

8e61877

Check path to PHP interpreter, array values not to lower case.

0369f0e

Move info message around, add function to report files that could not…

38eec7c

… be scanned.

gudmdharalds added 12 commits March 4, 2022 19:28

Update to match tests.

fab1ed3

Use function that reports when scanning files fails.

ef0dd7d

Add HTML entity decode ability.

8d2fbb1

Update test to lint using multiple PHP versions.

0e5a269

Adding PHP linting emulator.

ee60936

Updating helper, can now return different PHP versions depending on p…

ec53c47

…ath used.

Adding comment.

7d46efd

Helper functions.

55ccce7

Updating config to match new unittests.ini.dist and updated tests.

cd14a4b

Update test to match function.

41763eb

Update test to match function.

489c65e

Adding helper.

7b48508

wpcomvip-vipgoci-bot reviewed Mar 4, 2022

View reviewed changes

gudmdharalds added 10 commits March 4, 2022 21:06

Do not ask for commit info, not used.

1c3d28d

Adding helper directory to exception list.

9f6aa62

Adding test

b92f259

Check if returned value is not null.

8b28936

Update html_entity_decode() usage.

9dd8149

New test

540de65

Update test to match function, check failure situation.

7aae71f

Remove option not needed anymore.

c4e5c7c

Rename option to match unittests.ini.dist

23ce64b

Update README with information about new options.

e060179

gudmdharalds merged commit 4adfd94 into main Mar 7, 2022

gudmdharalds deleted the lint-multi-version branch March 7, 2022 13:26

gudmdharalds added the [Pri] Normal label Oct 25, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

PHP lint using multiple PHP versions #255

PHP lint using multiple PHP versions #255

gudmdharalds commented Mar 2, 2022 •

edited

Loading

wpcomvip-vipgoci-bot left a comment

Software versions

Options file (`.vipgoci_options`)

PHP lint options

SVG configuration

Auto-approval configuration

PHPCS configuration

wpcomvip-vipgoci-bot left a comment

Software versions

Options file (`.vipgoci_options`)

PHP lint options

SVG configuration

Auto-approval configuration

PHPCS configuration

wpcomvip-vipgoci-bot commented Mar 7, 2022

Software versions

Options file (`.vipgoci_options`)

PHP lint options

SVG configuration

Auto-approval configuration

PHPCS configuration

PHP lint using multiple PHP versions #255

PHP lint using multiple PHP versions #255

Conversation

gudmdharalds commented Mar 2, 2022 • edited Loading

wpcomvip-vipgoci-bot left a comment

Choose a reason for hiding this comment

Software versions

Options file (.vipgoci_options)

PHP lint options

SVG configuration

Auto-approval configuration

PHPCS configuration

wpcomvip-vipgoci-bot left a comment

Choose a reason for hiding this comment

Software versions

Options file (.vipgoci_options)

PHP lint options

SVG configuration

Auto-approval configuration

PHPCS configuration

wpcomvip-vipgoci-bot commented Mar 7, 2022

Software versions

Options file (.vipgoci_options)

PHP lint options

SVG configuration

Auto-approval configuration

PHPCS configuration

gudmdharalds commented Mar 2, 2022 •

edited

Loading

Options file (`.vipgoci_options`)

Options file (`.vipgoci_options`)

Options file (`.vipgoci_options`)