New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update string function usage for PHP 8 #249

Merged

gudmdharalds merged 1 commit into main from fix-substr-strpos

Feb 23, 2022

Contributor

gudmdharalds commented Feb 23, 2022 •

edited

Loading

This pull request updates usage of string functions.

TODO:

substr() in PHP 8.0 and later returns empty string rather than false (see here). Update code accordingly.
Check strpos() usage, as it is changed in PHP 8.0 (see here).
Check strrpos() usage due to same reasons.
Check automated unit-tests
Changelog entry (for VIP) [ Changelog for version 1.2.0 #243 ]


          substr() in PHP 8.0 and later returns empty string rather than false.

eb7c922

gudmdharalds added [Type] Enhancement [Pri] High labels

gudmdharalds added this to the 1.2.0 milestone

gudmdharalds self-assigned this

gudmdharalds merged commit 8c25da4 into main

gudmdharalds deleted the fix-substr-strpos branch

February 23, 2022 13:48

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Pri] High [Type] Enhancement