Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating TODO lists in PR templates and changelog link #241

Merged
merged 2 commits into from
Jan 31, 2022
+26 −4
Merged

Updating TODO lists in PR templates and changelog link #241

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
aea7932
Updating TODO lists in PR templates
gudmdharalds Jan 31, 2022
90c0acc
Update link for 1.1.3
gudmdharalds Jan 31, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 25 additions & 3 deletions .github/PULL_REQUEST_TEMPLATE
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,23 +3,45 @@
<!-- Please have a look at the document on contributing before submitting a pull request: https://github.com/Automattic/vip-go-ci/blob/main/CONTRIBUTING.md -->

<!--
Pull-Requests should have a TODO included. Here is a draft:

Pull-Requests should have a TODO included. Here are three drafts. Please select the one that applies to the contents of your pull request.

***

Draft for a patch:

TODO:
- [ ] Add/update unit-tests (if needed)
- [ ] Check automated unit-tests
- [ ] Add or update `PHPDoc` comments for new or updated functions (main code only; for VIP)
- [ ] Changelog entry (for VIP)

***

Draft for a feature pull request:

TODO:
- [ ] Specify a parameter to make [feature] configurable
- [ ] Implement [new feature / logic]
- [ ] Add/update unit-tests
- [ ] Add or update `PHPDoc` comments for new or updated functions (main code only).
- [ ] Add or update `PHPDoc` comments for new or updated functions (main code only)
- [ ] Update README
- [ ] Changelog entry
- [ ] Public documentation changes
- [ ] Run full-unit tests
- [ ] Check automated unit-tests

***

Draft for a changelog pull request:

TODO:
- [ ] Run full-unit tests
- [ ] Manual testing
- [ ] Pull request with PHP linting issues
- [ ] Pull request with PHPCS issues
- [ ] Pull request without PHPCS issues, not auto-approved
- [ ] Pull request without PHPCS issues, is auto-approved
- [ ] Pull request with SVG issues
- [ ] Pull request with large file to be skipped

-->
2 changes: 1 addition & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

All notable changes to this project will be documented in this file.

## [1.1.3](https://github.com/Automattic/vip-go-ci/releases/tag/1.1.2) - 2022-01-31
## [1.1.3](https://github.com/Automattic/vip-go-ci/releases/tag/1.1.3) - 2022-01-31

### Added
- [#239](https://github.com/Automattic/vip-go-ci/pull/239): Define version 1.1.3
Expand Down