-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding PHP 8.1 support and related changes #236
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Auto-approved Pull-Request #236 as it contains only auto-approvable files -- either pre-approved files, non-functional changes to PHP files or file-types that are auto-approvable (css
, csv
, eot
, gif
, gz
, ico
, ini
, jpeg
, jpg
, json
, less
, map
, md
, mdown
, mo
, mp4
, otf
, pcss
, pdf
, po
, pot
, png
, sass
, scss
, styl
, ttf
, txt
, woff
, woff2
, yml
).
…pdate-php-8 Signed-off-by: Gudmundur Haraldsson <gudmundur.haraldsson@automattic.com>
Dismissing obsolete review; not approved any longer
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Auto-approved Pull-Request #236 as it contains only auto-approvable files -- either pre-approved files, non-functional changes to PHP files or file-types that are auto-approvable (css
, csv
, eot
, gif
, gz
, ico
, ini
, jpeg
, jpg
, json
, less
, map
, md
, mdown
, mo
, mp4
, otf
, pcss
, pdf
, po
, pot
, png
, sass
, scss
, styl
, ttf
, txt
, woff
, woff2
, yml
).
Dismissing obsolete review; not approved any longer
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
phpcs scanning turned up:
🚫 11 errors
This bot provides automated PHP linting and PHPCS scanning. For more information about the bot and available customizations, see our documentation.
Add section on PHP linting. Path to run PHP for PHP Linting, PHPCS and SVG can be configured.
TODO:
--php-path
to--lint-php-path
--phpcs-php-path
option--svg-php-path
optionvip-go-ci
--lint-php-path
option--phpcs-php-path
option--svg-php-path
optionexec.php
phpcs-scan.php
lint-scan.php
svg-scan.php
vip-go-ci.php