Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding PHP 8.1 support and related changes #236

Merged
merged 50 commits into from
Feb 14, 2022
Merged

Adding PHP 8.1 support and related changes #236

merged 50 commits into from
Feb 14, 2022

Conversation

gudmdharalds
Copy link
Contributor

@gudmdharalds gudmdharalds commented Jan 25, 2022

TODO:

  • Add new and update options
    • Rename --php-path to --lint-php-path
    • Add --phpcs-php-path option
    • Add --svg-php-path option
  • Update README
    • PHP version for linting can be different from executing vip-go-ci
    • Same with PHPCS and SVG scanning
    • Document --lint-php-path option
    • Document --phpcs-php-path option
    • Document --svg-php-path option
  • Update CircleCI config
    • PHP 8.0 version is used for PHP linting
    • PHP 7.4 is used for PHPCS scanning
    • PHP 8.1 is used for SVG scanning
    • Update tests section to explain this
  • Apply WordPress coding standard to files
    • exec.php
    • phpcs-scan.php
    • lint-scan.php
    • svg-scan.php
    • vip-go-ci.php
  • Changelog entry [ Changelog for version 1.2.0 #243 ]
  • Add/update unit-tests
  • Run unit tests suite
  • Run integration tests suite
  • Check automated unit-tests
  • Manual testing
    • Pull request with PHP linting issues
    • Pull request with PHPCS issues
    • Pull request without PHPCS issues, not auto-approved
    • Pull request without PHPCS issues, is auto-approved
    • Pull request with SVG issues
    • Pull request with large file to be skipped

@gudmdharalds gudmdharalds added this to the PHP 8 support milestone Jan 25, 2022
@gudmdharalds gudmdharalds self-assigned this Jan 25, 2022
Copy link
Collaborator

@wpcomvip-vipgoci-bot wpcomvip-vipgoci-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approved Pull-Request #236 as it contains only auto-approvable files -- either pre-approved files, non-functional changes to PHP files or file-types that are auto-approvable (css, csv, eot, gif, gz, ico, ini, jpeg, jpg, json, less, map, md, mdown, mo, mp4, otf, pcss, pdf, po, pot, png, sass, scss, styl, ttf, txt, woff, woff2, yml).

@wpcomvip-vipgoci-bot wpcomvip-vipgoci-bot dismissed their stale review February 1, 2022 13:11

Dismissing obsolete review; not approved any longer

@gudmdharalds gudmdharalds modified the milestones: PHP 8 support, 1.2.0 Feb 4, 2022
Copy link
Collaborator

@wpcomvip-vipgoci-bot wpcomvip-vipgoci-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approved Pull-Request #236 as it contains only auto-approvable files -- either pre-approved files, non-functional changes to PHP files or file-types that are auto-approvable (css, csv, eot, gif, gz, ico, ini, jpeg, jpg, json, less, map, md, mdown, mo, mp4, otf, pcss, pdf, po, pot, png, sass, scss, styl, ttf, txt, woff, woff2, yml).

@gudmdharalds gudmdharalds changed the title Adding PHP 8.1 support Adding PHP 8.1 support and related changes Feb 9, 2022
@wpcomvip-vipgoci-bot wpcomvip-vipgoci-bot dismissed their stale review February 9, 2022 15:15

Dismissing obsolete review; not approved any longer

Copy link
Collaborator

@wpcomvip-vipgoci-bot wpcomvip-vipgoci-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

phpcs scanning turned up:

🚫 11 errors

⚠️ 4 warnings


This bot provides automated PHP linting and PHPCS scanning. For more information about the bot and available customizations, see our documentation.

lint-scan.php Show resolved Hide resolved
lint-scan.php Show resolved Hide resolved
lint-scan.php Show resolved Hide resolved
lint-scan.php Show resolved Hide resolved
lint-scan.php Show resolved Hide resolved
tests/integration/PhpcsScanDoScanTest.php Show resolved Hide resolved
tests/integration/PhpcsScanDoScanTest.php Show resolved Hide resolved
tests/integration/SvgScanWithScannerTest.php Show resolved Hide resolved
@gudmdharalds gudmdharalds merged commit 60ef498 into main Feb 14, 2022
@gudmdharalds gudmdharalds deleted the update-php-8 branch February 14, 2022 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants