Add request changes deduplication logic #218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It should cover messages that have other error messages concatenated to it. Add refactor to avoid dupication code in regards to the large files message build
ariskataoka
deleted the
hotfix/fix-logic-not-duplicate-comments-squashed
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Large files comment logic should cover messages that have other error messages concatenated to them and also the requested changes comments. This PR address that.
Add refactor to avoid duplication code in regards to the skipped large files message.
Correct message after two build execution with request changes (not duplicating request changes):
Correct message after two build execution(not duplicating info comment):
TODO:
PHPDoccomments for new or updated functions (main code only).