Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Break vipgoci_run() into multiple functions #207

Merged
merged 222 commits into from
Feb 9, 2022
Merged

Break vipgoci_run() into multiple functions #207

Changes from 1 commit
Commits
Show all changes
222 commits
Select commit Hold shift + click to select a range
dd56a82
Move if check to vipgoci_lint_scan_commit()
gudmdharalds Sep 7, 2021
95f55da
Move if check to vipgoci_phpcs_scan_commit()
gudmdharalds Sep 7, 2021
d8f678b
Comment on PHP 8.0
gudmdharalds Sep 13, 2021
f9c7e96
Updating PHP 8
gudmdharalds Sep 13, 2021
ea64ede
Fixing whitespacing.
gudmdharalds Sep 13, 2021
94b880c
New exit code (220) and updated --max-exec-time docs.
gudmdharalds Sep 13, 2021
f55617a
New exit code (220) and minimum PHP version defined.
gudmdharalds Sep 13, 2021
d8f84af
Breaking vipgoci_run() into multiple functions.
gudmdharalds Sep 13, 2021
7cf2989
Updated auto-approvals after restructure.
gudmdharalds Sep 13, 2021
5449700
Move functionality to auto-approval.php
gudmdharalds Sep 13, 2021
72502b5
Updating PHPDoc
gudmdharalds Sep 14, 2021
0e3cb77
Whitespacing
gudmdharalds Sep 14, 2021
0e97ce6
PHPDoc update, defining variable types.
gudmdharalds Sep 14, 2021
e0047e0
Adding 'lint' option.
gudmdharalds Sep 14, 2021
6f4f7ca
Adding 'phpcs' option.
gudmdharalds Sep 14, 2021
2f6f490
Adding 'phpcs' option.
gudmdharalds Sep 14, 2021
1a0799f
Removing @codeCoverageIgnore for two functions
gudmdharalds Sep 14, 2021
4673acc
Unit test for vipgoci_help_print()
gudmdharalds Sep 20, 2021
dea9e1a
Unit test for vipgoci_options_recognized()
gudmdharalds Sep 20, 2021
e46c671
Unit test for vipgoci_run_cleanup_phpcs()
gudmdharalds Sep 20, 2021
e1bd744
Unit test for vipgoci_run_env_options_handle()
gudmdharalds Sep 20, 2021
735c162
Unit test for vipgoci_run_init_options_max_exec_time()
gudmdharalds Sep 20, 2021
65498f0
Unit test for vipgoci_run_init_options_phpcs()
gudmdharalds Sep 20, 2021
39591d3
Set --phpcs to false by default, remove whitespace.
gudmdharalds Sep 20, 2021
a7491ce
Add vipgoci_unittests_options_test()
gudmdharalds Sep 20, 2021
2bea0a0
Adding @codeCoverageIgnore for vipgoci_run_init_options_autoapprove()
gudmdharalds Sep 20, 2021
d38de9d
@codeCoverageIgnore in a few places, rewrote vipgoci_run_init_options…
gudmdharalds Sep 28, 2021
8fc819a
Modifications to vipgoci_option_url_handle() in case of HTTPS URLs.
gudmdharalds Sep 28, 2021
e6c54c9
Merge branch 'main' into update-main-run-multiple-functions
gudmdharalds Sep 28, 2021
73fbcfe
Adding test for vipgoci_run_scan_log_skipped_files()
gudmdharalds Sep 28, 2021
68dc0e7
Fix problems noted by Bot.
gudmdharalds Sep 28, 2021
c389ba0
Merge branch 'update-main-run-multiple-functions' of github.com:Autom…
gudmdharalds Sep 28, 2021
62853fb
Test for vipgoci_run_init_vars()
gudmdharalds Sep 28, 2021
894a48a
Add test for vipgoci_run_init_options_autoapprove()
gudmdharalds Sep 28, 2021
07925b0
Add test for vipgoci_run_init_options_debug()
gudmdharalds Sep 28, 2021
cc5bf03
Test for vipgoci_run_init_options_lint()
gudmdharalds Sep 28, 2021
485af53
Adding test for vipgoci_run_init_options_hashes_options()
gudmdharalds Sep 28, 2021
78a4b78
Adding test for vipgoci_run_init_options_pixel_api()
gudmdharalds Sep 28, 2021
0d05712
Adding comment.
gudmdharalds Sep 28, 2021
2be2955
Test for vipgoci_run_init_options_post_generic_pr_support_comments()
gudmdharalds Sep 28, 2021
a83ead1
Adding test for vipgoci_run_init_options_repo_meta_api()
gudmdharalds Sep 28, 2021
d2675c5
Tests for vipgoci_run_init_options_reviews()
gudmdharalds Sep 28, 2021
755cbc2
Adding tests for vipgoci_run_init_options_svg()
gudmdharalds Sep 28, 2021
984b9e2
Adding tests for vipgoci_run_init_options_skip_large_files()
gudmdharalds Sep 28, 2021
cc77fa8
Adding tests for vipgoci_run_init_options_set_support_level_label()
gudmdharalds Sep 28, 2021
7c05f95
Moving to new dir structure
gudmdharalds Jan 25, 2022
9bab41d
Merge branch 'main' into update-main-run-multiple-functions
gudmdharalds Jan 25, 2022
8c3e1cc
Merge branch 'main' into update-main-run-multiple-functions
gudmdharalds Jan 25, 2022
289308f
Re-configure as unit-test
gudmdharalds Jan 25, 2022
e0cb75c
Adding defines.php
gudmdharalds Jan 25, 2022
5be0e6f
Moving to correct folder.
gudmdharalds Jan 25, 2022
1c3458d
Re-configure as unit-test
gudmdharalds Jan 25, 2022
6136dcd
Moving to correct folder.
gudmdharalds Jan 25, 2022
e157bd8
Run unit tests first.
gudmdharalds Jan 25, 2022
90b9fff
Re-configure as unit-test
gudmdharalds Jan 25, 2022
1268925
Moving to correct folder.
gudmdharalds Jan 25, 2022
81f9047
Moving to unit-test folder, re-configure as unit-test
gudmdharalds Jan 25, 2022
70b8bcb
Adding required file.
gudmdharalds Jan 25, 2022
7ce4e3e
Moving functions relating to output control to new file
gudmdharalds Jan 25, 2022
ae06590
Remove functions either moved to helper or new file.
gudmdharalds Jan 25, 2022
da1a878
Adding new file to ignore list.
gudmdharalds Jan 25, 2022
7b738a0
Require file with output control functions
gudmdharalds Jan 25, 2022
0871a6d
Moving to unit-test folder, re-configure as unit-test
gudmdharalds Jan 25, 2022
a108f6f
Moving to unit-test folder, re-configure as unit-test
gudmdharalds Jan 25, 2022
c79db08
Moving to unit-test folder, re-configure as unit-test
gudmdharalds Jan 25, 2022
37f5a59
Moving to unit-test folder, re-configure as unit-test
gudmdharalds Jan 25, 2022
141df6e
Moving to unit-test folder, re-configure as unit-test
gudmdharalds Jan 25, 2022
c026095
Adding lint-modified-files-only option
gudmdharalds Jan 25, 2022
579ec66
Changing namespace
gudmdharalds Jan 25, 2022
643f2dc
Moving to integration
gudmdharalds Jan 25, 2022
83f2b17
Moving to unit-test folder, re-configure as unit-test
gudmdharalds Jan 25, 2022
82f4bce
Declare strict types
gudmdharalds Jan 25, 2022
6e05993
Moving to unit-test folder, re-configure as unit-test
gudmdharalds Jan 25, 2022
0e936a2
Moving to unit-test folder, re-configure as unit-test
gudmdharalds Jan 25, 2022
cb4b82a
Moving to unit-test folder, re-configure as unit-test
gudmdharalds Jan 25, 2022
c593e0d
Moving to unit-test folder, re-configure as unit-test
gudmdharalds Jan 25, 2022
474b10d
Moving to unit-test folder, re-configure as unit-test
gudmdharalds Jan 25, 2022
6e22040
Moving to unit-test folder, re-configure as unit-test
gudmdharalds Jan 25, 2022
ef95b0b
Moving to unit-test folder, re-configure as unit-test
gudmdharalds Jan 25, 2022
1ddbe4f
Moving to integration-test folder
gudmdharalds Jan 25, 2022
0919eb4
Declare strict type for skeleton
gudmdharalds Jan 25, 2022
1eefcfc
Adding test for vipgoci_run_init_options_repo_options()
gudmdharalds Jan 25, 2022
413ec96
Split IncludesForTests.php into multiple files
gudmdharalds Jan 27, 2022
a5d09bf
Split IncludesForTests.php into multiple files
gudmdharalds Jan 27, 2022
d70c3ab
Adding new files to whitelist
gudmdharalds Jan 27, 2022
f6a6e1e
Remove PHP 8.0 note
gudmdharalds Jan 28, 2022
b2687d7
Sort options in vipgoci_run_init_options_repo_options()
gudmdharalds Jan 28, 2022
e9a9267
Update badge in README.md
gudmdharalds Jan 31, 2022
6670e3b
Merge branch 'main' into update-main-run-multiple-functions
gudmdharalds Feb 1, 2022
e7199ef
PHP 8 fix for getopt()
gudmdharalds Feb 1, 2022
fe4a899
Adding test for vipgoci_run_scan_total_comments_max_warning_post()
gudmdharalds Feb 1, 2022
cdac6cc
Add unit-test check in relation to vipgoci_run_scan_skip_execution()
gudmdharalds Feb 1, 2022
31aac13
Removing @codeCoverageIgnore for functions with tests
gudmdharalds Feb 1, 2022
b42a816
Adding test for vipgoci_run_scan_skip_execution()
gudmdharalds Feb 1, 2022
b13ae82
Fix checks in test
gudmdharalds Feb 1, 2022
70eaaab
Adding declare(strict_types=1); for vip-go-ci.php
gudmdharalds Feb 1, 2022
e1b728a
Adding declare(strict_types=1);
gudmdharalds Feb 1, 2022
5ad597d
Replacing "\ŧ" with "\t"
gudmdharalds Feb 1, 2022
633dace
PHP 8 fix for getopt()
gudmdharalds Feb 1, 2022
41f5464
Removing info about maximum exec time, we now attempt to correct for …
gudmdharalds Feb 1, 2022
61d38d1
Adding test for vipgoci_set_maximum_exec_time()
gudmdharalds Feb 2, 2022
b2bb6cc
Check if PCNTL is supported.
gudmdharalds Feb 2, 2022
4505a2d
Add CheckPcntlSupport.php
gudmdharalds Feb 2, 2022
244fae2
Add helper to check for PCNTL support
gudmdharalds Feb 2, 2022
caaa3af
Install PHP PCNTL module
gudmdharalds Feb 2, 2022
ca2d650
Change indication string due to possible incompatibility
gudmdharalds Feb 2, 2022
f6ab618
More detailed test for alarm
gudmdharalds Feb 2, 2022
f269544
Adjust alarm tests
gudmdharalds Feb 2, 2022
a2335f6
Adjust seconds a bit
gudmdharalds Feb 2, 2022
68778cf
Run in separate process
gudmdharalds Feb 2, 2022
c823e41
Log to IRC when exiting due to reaching GitHub API limit
gudmdharalds Feb 2, 2022
cae0f5d
Do not preserve global state when running tests
gudmdharalds Feb 2, 2022
febc436
Comment about @runTestsInSeparateProcesses and @preserveGlobalState
gudmdharalds Feb 2, 2022
da69d1f
Print output if in debug mode, use different assertations
gudmdharalds Feb 2, 2022
ec16a00
Removing VIPGOCI_UNIT_TESTS_TEST_ID_KEY, lives in unit-test helper now
gudmdharalds Feb 2, 2022
ffb6f5e
Adding more testing for vipgoci_run_init_github_token_option()
gudmdharalds Feb 2, 2022
34876de
Adding tests for vipgoci_run_scan_reviews_comments_enforce_maximum()
gudmdharalds Feb 2, 2022
6e4a816
Renaming file
gudmdharalds Feb 2, 2022
cdb4266
Update test
gudmdharalds Feb 2, 2022
e694b48
Adding test for vipgoci_run_init_options_autoapprove_hashes_overlap()
gudmdharalds Feb 2, 2022
3d4a7be
Adding test for vipgoci_run_cleanup_irc()
gudmdharalds Feb 2, 2022
0987f43
Log when clearing IRC queue is not attempted
gudmdharalds Feb 2, 2022
140db14
Moving into integration tests
gudmdharalds Feb 2, 2022
0fe718c
Adding test for vipgoci_run_cleanup_send_pixel_api()
gudmdharalds Feb 2, 2022
b7193bb
Updates
gudmdharalds Feb 2, 2022
274042f
Define variable types, add PHPDoc comment.
gudmdharalds Feb 4, 2022
8de2b0b
Define variable types, add PHPDoc comment.
gudmdharalds Feb 4, 2022
820c921
Define variable types, add PHPDoc comment.
gudmdharalds Feb 4, 2022
d1631cb
Define variable types, add PHPDoc comment.
gudmdharalds Feb 4, 2022
3c4f7f1
Define variable types, add PHPDoc comment.
gudmdharalds Feb 4, 2022
ee6fd4b
Define variable types, add PHPDoc comment.
gudmdharalds Feb 4, 2022
cf4ef2d
require_once() to setUp(), separate process, PHPDoc comments update, …
gudmdharalds Feb 4, 2022
e2cf937
Adding helper for vipgoci_irc_api_alert_queue()
gudmdharalds Feb 4, 2022
d020187
Removing whitespacing
gudmdharalds Feb 4, 2022
9336bde
Define as object
gudmdharalds Feb 4, 2022
7a25b4a
Provide path to temporary git repository.
gudmdharalds Feb 4, 2022
039dd06
Update PHPDoc comment
gudmdharalds Feb 4, 2022
a117cd5
Update PHPDoc comment
gudmdharalds Feb 4, 2022
7b0a13e
Update PHPDoc comment
gudmdharalds Feb 4, 2022
7623308
Update comment
gudmdharalds Feb 4, 2022
42f58d7
Run in separate process, do not preserve global state
gudmdharalds Feb 4, 2022
ab78884
Rename tests so that prefix matches file were function lives
gudmdharalds Feb 4, 2022
3a0c15f
Rename tests to fit with pattern
gudmdharalds Feb 4, 2022
692b7e1
Run in separate processes, do not preserve global state.
gudmdharalds Feb 4, 2022
61fa886
Print when minimum requirements are passed
gudmdharalds Feb 4, 2022
407e365
Coding standard fixes
gudmdharalds Feb 7, 2022
db53742
Coding standard fixes
gudmdharalds Feb 7, 2022
a07bc92
Coding standard fixes
gudmdharalds Feb 7, 2022
d51b986
Coding standard fixes
gudmdharalds Feb 7, 2022
bdd4b6c
Coding standard fixes
gudmdharalds Feb 7, 2022
ce0e576
Coding standard fixes
gudmdharalds Feb 7, 2022
d82daae
Add PHPCS sniffs to exclude
gudmdharalds Feb 7, 2022
792a585
Coding standard fixes
gudmdharalds Feb 7, 2022
5990467
Coding standard fixes.
gudmdharalds Feb 7, 2022
e08dfb2
Coding standard fixes.
gudmdharalds Feb 7, 2022
0da67a6
Do not run PHP 7.3 checks due to failure, will be removed soon in #236.
gudmdharalds Feb 7, 2022
bd6675e
Coding style fixes
gudmdharalds Feb 7, 2022
764464f
Coding style fixes
gudmdharalds Feb 7, 2022
1ead337
Coding style fixes
gudmdharalds Feb 7, 2022
4a60fb8
Coding style fixes
gudmdharalds Feb 8, 2022
46284a8
Coding style fixes
gudmdharalds Feb 8, 2022
37733eb
Coding style fixes
gudmdharalds Feb 8, 2022
9cbd55a
Coding style fixes
gudmdharalds Feb 8, 2022
0ddee28
Coding style fixes
gudmdharalds Feb 8, 2022
2259eab
Coding style fixes
gudmdharalds Feb 8, 2022
fc7be5e
Coding style fixes
gudmdharalds Feb 8, 2022
c173cf1
Coding style fixes
gudmdharalds Feb 8, 2022
1392d90
Coding style fixes
gudmdharalds Feb 8, 2022
97ba7e0
Coding style fixes
gudmdharalds Feb 8, 2022
6927068
Coding style fixes
gudmdharalds Feb 8, 2022
f163f08
Coding style fixes
gudmdharalds Feb 8, 2022
0085b26
Coding style fixes
gudmdharalds Feb 8, 2022
03a85e8
Coding style fixes
gudmdharalds Feb 8, 2022
1cd7903
Coding style fixes
gudmdharalds Feb 8, 2022
c2a0ae9
Coding style fixes
gudmdharalds Feb 8, 2022
5424e7a
Coding style fixes
gudmdharalds Feb 8, 2022
ab4dd57
Coding style fixes
gudmdharalds Feb 8, 2022
0afb174
Coding style fixes
gudmdharalds Feb 8, 2022
bf6391a
Coding style fixes
gudmdharalds Feb 8, 2022
fa60969
Coding style fixes
gudmdharalds Feb 8, 2022
f2bba5d
Coding style fixes
gudmdharalds Feb 8, 2022
8d5730c
Coding style fixes
gudmdharalds Feb 8, 2022
d889095
Coding style fixes
gudmdharalds Feb 8, 2022
4fc0d0d
Coding style fixes
gudmdharalds Feb 8, 2022
f030cb2
Coding style fixes
gudmdharalds Feb 8, 2022
bb6d94f
Coding style fixes
gudmdharalds Feb 8, 2022
0c27fc4
Coding style fixes
gudmdharalds Feb 8, 2022
45ac206
Coding style fixes
gudmdharalds Feb 8, 2022
c3d0078
Coding style fixes
gudmdharalds Feb 8, 2022
3efbacb
Coding style fixes
gudmdharalds Feb 8, 2022
335545f
Coding style fixes
gudmdharalds Feb 8, 2022
107b4df
Coding style fixes
gudmdharalds Feb 8, 2022
f3a0a70
Coding style fixes
gudmdharalds Feb 8, 2022
dac8eca
Coding style fixes
gudmdharalds Feb 8, 2022
8e201fb
Coding style fixes
gudmdharalds Feb 8, 2022
4e9cc82
Coding style fixes
gudmdharalds Feb 8, 2022
e88b94c
Coding style fixes
gudmdharalds Feb 8, 2022
4f9a2e5
Coding style fixes
gudmdharalds Feb 8, 2022
9a7966e
Coding style fixes
gudmdharalds Feb 8, 2022
11be6fa
Coding style fixes
gudmdharalds Feb 8, 2022
e6799fb
Add exceptions, temporarily; will be resolved in #244
gudmdharalds Feb 8, 2022
c6a41f1
Coding style fixes
gudmdharalds Feb 8, 2022
92625ed
Remove phpcs:disable
gudmdharalds Feb 8, 2022
d31dd87
Remove / from end of hashes-api-url option.
gudmdharalds Feb 8, 2022
fe1bfae
Test with URL ending with /
gudmdharalds Feb 8, 2022
7eba7b4
Fix --output option
gudmdharalds Feb 8, 2022
9ae3a46
Exit with error also if certain options are empty strings.
gudmdharalds Feb 8, 2022
e2cf3a5
Removing Squiz.PHP.DiscouragedFunctions
gudmdharalds Feb 8, 2022
c8ecaeb
Standardize ignorable messages
gudmdharalds Feb 8, 2022
0ee2c85
Remove obsolete phpcs:disable, move includes into setUp().
gudmdharalds Feb 8, 2022
d59ad9e
Update PHPDoc comment, rtrim() includes whitespacing chars.
gudmdharalds Feb 8, 2022
43e5ea9
Adding test for vipgci_results_standardize_ignorable_message()
gudmdharalds Feb 8, 2022
2688a22
Unit-test, require files differently, new function to standardize mes…
gudmdharalds Feb 8, 2022
ec08ef7
Update comment style to match coding standards.
gudmdharalds Feb 8, 2022
772446d
Update --help, move functionality around.
gudmdharalds Feb 8, 2022
cb93acc
Avoid performing PHPCS related actions when it is disabled.
gudmdharalds Feb 9, 2022
2c9904e
Fix problem with --phpcs=false and --lint=false
gudmdharalds Feb 9, 2022
eb524fd
Add --phpcs option to $this->options
gudmdharalds Feb 9, 2022
be25eb1
Fix coding style issues
gudmdharalds Feb 9, 2022
f23820b
Rename function so to use vipgoci_ prefix.
gudmdharalds Feb 9, 2022
a2da36b
Rename function to use vipgoci_ prefix.
gudmdharalds Feb 9, 2022
28724bd
Rename functions to use vipgoci_ prefix.
gudmdharalds Feb 9, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Removing @codeCoverageIgnore for two functions
  • Loading branch information
@gudmdharalds
gudmdharalds committed Sep 14, 2021
commit 1a0799f86238365605092e599173e8fd75e392af
4 changes: 0 additions & 4 deletions main.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,6 @@
* Print help message.
*
* @return void
*
* @codeCoverageIgnore
*/
function vipgoci_help_print() :void {
global $argv;
Expand Down Expand Up @@ -222,8 +220,6 @@ function vipgoci_help_print() :void {
* Returns options supported.
*
* @return array Recognized options.
*
* @codeCoverageIgnore
*/
function vipgoci_options_recognized() :array {
return array(
Expand Down