Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate SVG files, added details to message, and formatting changed slightly, add logging #198

Merged
merged 18 commits into from
Aug 18, 2021

Conversation

gudmdharalds
Copy link
Contributor

@gudmdharalds gudmdharalds commented Aug 17, 2021

TODO:

  • Validate SVG files
    • Update SVG unit-test SvgScanScanSingleFileTest
    • Set up SvgScanScanCommitTest
  • Add explanatory message when skipped files are noted
  • Alter formatting slightly for outputted message for consistency and easier reading
  • Update VipgociSkipFileTest test to match code
  • Log when files are skipped due to length
  • Update unit-tests as needed
  • Changelog entry [Adding changelog entry for version 1.0.8 #190]
  • Check automated unit-tests

@gudmdharalds gudmdharalds added this to the 1.0.8 milestone Aug 17, 2021
@gudmdharalds gudmdharalds self-assigned this Aug 17, 2021
@gudmdharalds gudmdharalds merged commit 6321347 into master Aug 18, 2021
Copy link
Collaborator

@wpcomvip-vipgoci-bot wpcomvip-vipgoci-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

phpcs scanning turned up:

🚫 1 error

⚠️ 1 warning


This bot provides automated PHP linting and PHPCS scanning. For more information about the bot and available customizations, see our documentation.

@@ -0,0 +1,217 @@
<?php
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Warning( severity 5 ): A file should declare new symbols (classes, functions, constants, etc.) and cause no other side effects, or it should execute logic with side effects, but should not do both. The first symbol is defined on line 20 and the first side effect is on line 3 (PSR1.Files.SideEffects.FoundWithSymbols).

* Here we only test if SVG scanning does work
* as expected.
*/
final class SvgScanScanCommitTest extends TestCase {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 Error( severity 5 ): Each class must be in a namespace of at least one level (a top-level vendor name) (PSR1.Classes.ClassDeclaration.MissingNamespace).

@gudmdharalds gudmdharalds deleted the fix-misc-issues branch August 19, 2021 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants