Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renaming option --results-comments-sort to --review-comments-sort #177

Merged
merged 4 commits into from
May 26, 2021

Conversation

gudmdharalds
Copy link
Contributor

@gudmdharalds gudmdharalds commented May 26, 2021

Renaming option --results-comments-sort to --review-comments-sort to be in line with naming of current options.

TODO:

@gudmdharalds gudmdharalds added this to the 1.0.6 milestone May 26, 2021
@gudmdharalds gudmdharalds self-assigned this May 26, 2021
Copy link
Collaborator

@wpcomvip-vipgoci-bot wpcomvip-vipgoci-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

phpcs scanning turned up:

🚫 1 error

⚠️ 1 warning


This bot provides automated PHP Linting and PHPCS scanning, read more here.

tests/ReviewCommentsSortTest.php Show resolved Hide resolved
tests/ReviewCommentsSortTest.php Show resolved Hide resolved
@gudmdharalds gudmdharalds merged commit 75d8e6a into master May 26, 2021
@gudmdharalds gudmdharalds deleted the rename-results-comments-sort branch June 4, 2021 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants