Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make messages in IRC queue unique before sending #173

Merged
merged 3 commits into from
May 17, 2021

Conversation

gudmdharalds
Copy link
Contributor

@gudmdharalds gudmdharalds commented May 17, 2021

Sometimes messages to IRC are in duplicate. Here we ensure this does not happen by making all the messages unique before sending.

TODO:

  • Make messages in IRC queue unique before sending
  • Add unit-tests to test feature
  • Changelog entry
  • Check automated unit-tests

Copy link
Collaborator

@wpcomvip-vipgoci-bot wpcomvip-vipgoci-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

phpcs scanning turned up:

🚫 1 error


This bot provides automated PHP Linting and PHPCS scanning, read more here.

tests/A00IrcApiAlertQueueUniqueTest.php Show resolved Hide resolved
@gudmdharalds gudmdharalds added this to the 1.0.5 milestone May 17, 2021
@gudmdharalds gudmdharalds merged commit e52d55f into master May 17, 2021
@gudmdharalds gudmdharalds deleted the add-irc-msg-unique branch May 21, 2021 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants