-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resolve issue with new git diff
mechanism
#166
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gudmdharalds
changed the title
Resolve issue with new
Resolve issue with new May 3, 2021
git diff
mechanism.git diff
mechanism
Implements: vipgoci_github_diffs_fetch_unfiltered() This function is needed as a fallback, when the local git repository does not have the data needed.
… repo diff function
wpcomvip-vipgoci-bot
previously requested changes
May 5, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
phpcs scanning turned up:
🚫 2 errors
This bot provides automated PHP Linting and PHPCS scanning, read more here.
7 tasks
gudmdharalds
added a commit
that referenced
this pull request
May 7, 2021
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve a problem with the new
git diff
mechanism which in some cases can cause unexpected problems.TODO:
git diff branch1...branch2
syntaxfatal: bad object [commit-ID]
, fallback to GitHub APIvip-go-ci
assumes a fully checked out repositoryvipgoci_github_diffs_fetch_unfiltered()
GitRepoDiffsFetchUncachedTest.php
toGitRepoDiffsFetchUnfilteredTest.php
GitRepoDiffsFetchUnfilteredTest.php
MiscPatchChangedLinesTest.php
as wellGitRepoDiffsFetchTest.php
as wellGitRepoDiffsFetchTest.php
toGitDiffsFetchTest.php
andvipgoci_gitrepo_diffs_fetch()
tovipgoci_git_diffs_fetch()
GitRepoDiffsFetchUnfilteredTest.php
andGitHubDiffsFetchUnfilteredTest.php
use the same test-data, as they should return the same resultsgit diff
via GitHub API andgit diff
via local repo returns the same data