Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add UMD support for use via npmcdn.com #3

Closed
wants to merge 1 commit into from

Conversation

bclinkinbeard
Copy link

This simply adds a UMD build so the lib can be used from places like JSBin, via npmcdn.com

I also added a npm run release script to enable running the build as part of the publish process. I did not use prepublish since it runs on install as well.

@TooTallNate
Copy link
Contributor

Why not just use a common js compatible CDN like https://wzrd.in/standalone/util-inspect@latest ?

@LinusU
Copy link
Contributor

LinusU commented May 24, 2016

I agree with TooTallNate and actually think that we shouldn't publish a UMD package. It will be downloaded to everyone using this module, even though it won't be needed.

That being said, just for reference, I would also recommend using prepublish script to ensure that it always runs before publishing a new version, and to add browserify to the devDependencies so that it's available when it's time to build. Might be good to know if you want to do this in any other repo 👌

@bclinkinbeard
Copy link
Author

Fair points

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants