Blockbase + children: remove __unstableLocation#6759
Conversation
| return false; | ||
| } | ||
|
|
||
| // The block should have an unstable location attribute. |
There was a problem hiding this comment.
Is there still value in including this now that the __unstableLocation is gone?
I don't see any themes that provide a custom.navigation/social-links value.
What other value does this provide? Can we get rid of it completely?
There was a problem hiding this comment.
Can we get rid of it completely?
I think so, but is there potential for it to break how social menus are displayed for some sites running Blockbase or its children? There are five header parts that would appear to use this filter:
https://github.com/Automattic/themes/blob/trunk/blockbase/parts/header-default.html#L19
https://github.com/Automattic/themes/blob/trunk/blockbase/parts/header-linear.html#L19
https://github.com/Automattic/themes/blob/trunk/blockbase/parts/header-minimal.html#L21
https://github.com/Automattic/themes/blob/trunk/blockbase/parts/header-rounded-logo.html#L19
https://github.com/Automattic/themes/blob/trunk/blockbase/parts/header-wide.html#L19
There was a problem hiding this comment.
Yes, I agree that for that reason it should stay. The remainder of what's left is unconnected to __unstableLocation and removing it just removes functionality.
pbking
left a comment
pbking
left a comment
There was a problem hiding this comment.
This is the change we need. It's refreshing to get that attribute out.
This can ship once Gutenberg 14.8 is available on wpcom simple sites.
jffng
force-pushed
the
try/remove-unstable-location
branch
from
84a9a6a to
2f2787d
Compare
2 participants
Changes proposed in this Pull Request:
WordPress/gutenberg#45976 added a fallback for classic menus assigned to the
primarylocation or namedprimary.Once that lands in the plugin (14.8), we should be able to safely remove this attribute without breaking user's navigations.
To test
Related issue(s):
Fixes #6738