#5097: Maywood: Fix image alignment

[bobmatyas]

Fixes image alignment in Maywood to bring frontend into parity with editor options

Changes proposed in this Pull Request:

Before

---

Editor:

Frontend:

After

---

Editor:

Frontend:

Related issue(s):

Fixes #5097

[pbking]

Maywood leverages SASS. Thus this change would require that the source file be changed and then recompile, but that source is actually in varia.

Thus deleting this CSS would effect ALL Varia themes. Which perhaps is desirable based on the issue described. But changing the CSS here would just get overwritten the next time the SASS was recompiled.

[bobmatyas]

Thanks for the feedback here.

I made a change in Varia to reflect this (built and tested) and rebuilt the child themes (npm run children). Based on this comment it seems like the change should happen in Varia: #5097 (comment)

I tested on Maywood and it fixed the issue. I also checked in Hever and Stratford and had no adverse effects.

Varia

Before

After

Maywood

Before

After

[pbking]

This looks like the right change to the SASS file to make the change you want. However it will still need to be compiled and the result of that compilation committed.

That's going to make for quite a few changed files, but that's how Varia and family works.

Run npm run build in the varia folder to build the CSS for Varia itself. Then (also in the varia folder) run ./rebuild-child-themes.sh (or npm run children which just calls that bash script).

The result with be a changed style.css, style-rtl.css and possibly a changed package-lock.json file for each varia theme which also needs to be committed to the PR.

Of course this means that the resulting behavior will be changed in all of these themes. Which could be argued is correct, but it's also a change and has the potential to change the layout of a lot of people's sites. Something to carefully consider when making the fix. (One person's 'fix' is another person's 'breakage'.)

[bobmatyas]

I can build the child themes and commit, but maybe this needs more discussion by the Theme team as to whether or not this should be fixed?

It seems like it is indeed not working properly (prior to the fix), but I am somewhat unsure whether or not it now makes sense to fix knowing that it will change so many themes. Theoretically, users shouldn't be relying on the auto-aligning since the editor was working properly and if they wanted center aligning, they would have had to manually do it.