This repository was archived by the owner on Feb 17, 2025. It is now read-only.
Added pendant/templates/page-about.html to meet the design suggested …#5759
Closed
PeterNdomano wants to merge 1 commit intoAutomattic:trunkfrom
Closed
Added pendant/templates/page-about.html to meet the design suggested …#5759PeterNdomano wants to merge 1 commit intoAutomattic:trunkfrom
PeterNdomano wants to merge 1 commit intoAutomattic:trunkfrom
Conversation
Contributor
|
A solid start. Check out how the layout is structured in this continuation of your other pull request. We can achieve edge-less (when needed) layout elements to make sure the gaps are only where we want them to be. Also, while I work this project I'm testing the workflow of editing the templates with the FSE and "saving" the work using the Create Block Theme plugin. If you're able to evaluate that while working on this (or other) themes your input would be appreciated. |
Contributor
Author
|
Thanks @pbking I had a look and understood what you meant. Also previously I wasn't using 'Create Block Theme' plugin but I'll start using it as soon as possible so expect my contribution on it too. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes proposed in this Pull Request:
Added and edited pendant/templates/page-about.html to meet the design suggested in #5745
Related issue(s):
#5745
About page look after applying above changes
@pbking