Seedlet & Spearhead Custom Link Color

[pbking]

Changes proposed in this Pull Request:

Changes the shape (or adds) theme.json files from the following Pull Requests:

Seedlet:
#3271
#3274

Spearhead:
#3133

Related issue(s):

#3243

Diff

D57441-code

[jffng]

Custom link colors are still not working for me in the view:

Editor	View

[scruffian]

It's not working in the view for me either - I tested in a cover block...

[pbking]

I found and fixed an issue with the cover block specifically where the specificity of some anchor styling was preventing the 'link' style from cascading properly.

I suspect there are other blocks with the same situation, I'll comb through spearhead and see where else it might be occurring.

@jeffikus I was unable to reproduce your screenshot however (tested both Spearhead and Seedlet). It only KINDA happened for me when I was testing and had SEEDLET in the editor, switched themes (but didn't reload the editor) and set the color to that green (secondary color) which isn't a color provided by Spearhead so it rolled back to the 'default'. But that seems like I was trying too hard...

[pbking]

Shoot...
The "cover block" fix noted above breaks styles when a custom link is NOT applied. Need to re-evaluate further...

[scruffian]

I pushed a fix to Seedlet colors for this, just needs another review...

[MaggieCabrera]

A cover block with custom link color shows differently on the editor vs the frontend:

Editor:

Frontend:

[scruffian]

Yeah sorry I forgot to update the editor styles too. Should be good to go now...

[pbking]

In the editor, in a GROUP with background {Primary}
A P with link-color set to {Foreground} renders correctly in the editor

but not so in the view:

Perhaps .has-link-color should be included in
.has-background:not(.has-background-background-color) a:not(.has-text-color):not(.wp-block-button__link) which is coloring the link to 'currentColor'.

[scruffian]

This will be a lot easier to resolve once this is fixed: WordPress/gutenberg#29557

[scruffian]

I removed a bunch of code from Seedlet to fix this. Some of this code was added in this PR: #3088

I think if you run the latest version of Gutenberg it will all work as expected, but there could be more cases I've not considered...

[MaggieCabrera]

I could not get this to break, it looks good to me!