This repository was archived by the owner on Feb 17, 2025. It is now read-only.
Simplify link selectors to avoid bleed#3109
Merged
Conversation
pbking
force-pushed
the
fix/3905-simplify-link-styles-prevent-bleeding
branch
from
f4b6ef0 to
1b9cf3b
Compare
scruffian
force-pushed
the
fix/3905-simplify-link-styles-prevent-bleeding
branch
from
1b9cf3b to
76ad1e8
Compare
scruffian
reviewed
Jan 27, 2021
scruffian
suggested changes
Jan 27, 2021
Member
scruffian
left a comment
scruffian
left a comment
There was a problem hiding this comment.
This breaks custom link colors
Member
|
See also: #3122 |
The link selectors were changed to apply a default border style to all anchors (with a loose selector, just 'a') but leave that border-color transparent. All of these elements get a :hover to apply the primary hover style. Any anchor that's in wp-block or entry-content will instead have those border color values inverted (defaults to --color-primary, hover is transparent) Buttons, social links (any other <a> that I found to evaluate) had more specific selection rules to eliminate the border-bottom styles preventing undesired underlines.
pbking
force-pushed
the
fix/3905-simplify-link-styles-prevent-bleeding
branch
from
76ad1e8 to
753b728
Compare
Contributor
Author
|
I tested with as many custom link configurations and methods as I could find. The only difference that I saw was that the custom link colors weren't turning to the primary color on hover; that has been addressed. If there are other custom link color issues please lmk. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes proposed in this Pull Request:
The link selectors were changed to apply a default border style to all
anchors (with a loose selector, just 'a') but leave that border-color
transparent. All of these elements get a :hover to apply the primary
hover style.
Any anchor that's in wp-block or entry-content will instead have those
border color values inverted (defaults to --color-primary, hover is
transparent)
Buttons, social links (any other that I found to evaluate) had more
specific selection rules to eliminate the border-bottom styles
preventing undesired underlines.
Related issue(s):
Closes #3095