Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the "Tested up to" after testing in WordPress 6.2 #258

Merged
merged 1 commit into from
Apr 17, 2023
Merged

Update the "Tested up to" after testing in WordPress 6.2 #258

merged 1 commit into from
Apr 17, 2023

Conversation

renatho
Copy link
Contributor

@renatho renatho commented Apr 17, 2023 •
edited
Loading

Changes proposed in this Pull Request

  • It just updates the "Tested up to" after testing in WordPress 6.2.
    • I'm updating it for parity, but I'm also updating it directly in the published plugin code without a release.

@renatho renatho added the [Type] Maintenance Changes to non-production files label Apr 17, 2023
@renatho renatho requested a review from a team April 17, 2023 18:39
@renatho renatho self-assigned this Apr 17, 2023
@renatho renatho changed the title Update tested up to 6.2 Update the "Tested up to" after testing in WordPress 6.2 Apr 17, 2023
@renatho renatho force-pushed the change/tested-up-to-6-2 branch from 05a7557 to a83b3ee Compare April 17, 2023 21:38
fjorgemota
fjorgemota approved these changes Apr 17, 2023 •
edited
Loading
View reviewed changes
fjorgemota
fjorgemota approved these changes Apr 17, 2023
View reviewed changes
Copy link
Member

@fjorgemota fjorgemota left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, just left a question, but the change per se is still approved.

readme.txt
@@ -3,7 +3,7 @@ Contributors: Viper007Bond, automattic, donncha
Donate link: https://alex.blog/2019/03/13/in-memory-of-alex-donation-link-update/
Tags: code, source, sourcecode, php, syntax highlighting, syntax, highlight, highlighting, highlighter, WordPress.com
Requires at least: 5.7
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't we bump this too? 👀

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think for this case that we're not introducing new features, we don't need to bump it. And we make sure that it's a change with less noise for the users using it too. :)

syntaxhighlighter.php
@@ -12,7 +12,7 @@
License: GPL2
License URI: https://www.gnu.org/licenses/gpl-2.0.html
Requires at least: 5.7
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't we bump this too? 👀

@renatho renatho merged commit 15a0fcb into master Apr 17, 2023
@thedebian thedebian deleted the change/tested-up-to-6-2 branch November 22, 2023 14:41
@fjorgemota fjorgemota mentioned this pull request Dec 4, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fjorgemota fjorgemota fjorgemota approved these changes

Assignees

@renatho renatho

Labels
[Type] Maintenance Changes to non-production files
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@renatho @fjorgemota