Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix incorrectly handled variable in translatable text #915

Merged
merged 1 commit into from
Feb 11, 2025
Merged

Fix incorrectly handled variable in translatable text #915

merged 1 commit into from
Feb 11, 2025

Conversation

wojtekn
Copy link
Contributor

@wojtekn wojtekn commented Feb 11, 2025

Related issues

  • N/A

Proposed Changes

  • I propose to fix incorrectly handled variable in translatable text.

Testing Instructions

  1. Start Studio:
STUDIO_QUICK_DEPLOYS=true npm start
  1. Confirm that the variable in new Previews tab still works fine

Pre-merge Checklist

  • Have you checked for TypeScript, React or other console errors?

@wojtekn wojtekn requested a review from a team February 11, 2025 11:21
@wojtekn wojtekn self-assigned this Feb 11, 2025
sejas
sejas approved these changes Feb 11, 2025
View reviewed changes
Copy link
Member

@sejas sejas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@wojtekn wojtekn merged commit 570cb6e into trunk Feb 11, 2025
7 checks passed
@wojtekn wojtekn deleted the fix/incorrect-translatable-text branch February 11, 2025 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sejas sejas sejas approved these changes

Assignees

@wojtekn wojtekn

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wojtekn @sejas