Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Preview Sites: Add
Clear
button for expired sites with related styling #913Preview Sites: Add
Clear
button for expired sites with related styling #913Changes from 7 commits
7a895b2
41ed24f
7b9f54c
00a4d62
83a21d0
f4f7d88
710737e
323002b
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've investigated if we have the color
text-a8c-gray-700
-#757575
, but it seems we don't have it. I've tried updatingautomattic/color-studio
but the new version 4.1.0 doesn't include it either.I think it's ok to leave it as it is, since we are using that color in the rest of the app, but we could consider adding a new variable in tailwind config.
Something like:
a8cToTailwindColors[
${ PREFIX }-gray-700] = '#757575'; // Gray 700
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's a great idea! Thanks! I have added the variable and replaced all occurrences of
#757575
in the latest commit: 323002b.