Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Studio: Switch order of buttons on the connected sites screen #616

Merged
merged 2 commits into from
Oct 24, 2024

Conversation

katinthehatsite
Copy link
Contributor

@katinthehatsite katinthehatsite commented Oct 24, 2024

Closes https://github.com/Automattic/dotcom-forge/issues/9486

Proposed Changes

This PR switches the order of the Connect site and Create new site on the Sync tab when the user has no connected sites.

Testing Instructions

  • Pull the changes from this branch
  • Start the app with STUDIO_SITE_SYNC=true npm start
  • Navigate to the Sync tab
  • Confirm that you can see the following design e.g. Connect site button first and Create new site button second:
Screenshot 2024-10-24 at 10 40 19 AM

Before these changes:

Screenshot 2024-10-24 at 10 46 35 AM

Design was introduced in this comment: p9Jlb4-ewp-p2#comment-13926

Pre-merge

Checklist

  • Have you checked for TypeScript, React or other console errors?

@katinthehatsite katinthehatsite self-assigned this Oct 24, 2024
@katinthehatsite katinthehatsite requested a review from a team October 24, 2024 08:53
Copy link
Member

@sejas sejas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I confirm I see the buttons in the correct order. I executed STUDIO_SITE_SYNC=true npm start.

Screenshot 2024-10-24 at 10 56 50

It's nice that now it also matches the buttons, for the connected screen:

Screenshot 2024-10-24 at 10 57 14

@katinthehatsite katinthehatsite merged commit e11e931 into trunk Oct 24, 2024
11 checks passed
@katinthehatsite katinthehatsite deleted the fix/switch-order-of-buttons branch October 24, 2024 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants