-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Studio: Add chat context #252
Conversation
NOTE: We ll need to change things if #213 is merged first. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested different prompts and worked great, awesome work @kozer 🏅 !
Additionally, I shared some comments but I think none should block the PR.
For reference, with the prompt Share the context of the site
we can easily see the values passed for the current site:
@fluiddot , I did all the changes you requested. Can you please check again? Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kozer , the happy path works great! I've been updating the php version and installing plugins. It works great. Here is an screenshot.
I have a concern about running wp-cli commands multiple times when the site or focus changes. I found that changing the site in the left sidebar has a performance issue and freezes the app, even in the overview tab. Is possible to fix it?
Hhodxe.mp4
17McGF.mp4
They look great, thanks 🙇 ! |
Oh, I've just noticed this issue when selecting different sites, thanks for spotting it @sejas. Sorry to overlook it when testing it, as it severely impacts the performance of basic actions like selecting sites 😞 . I think the main problem comes from the fact that the initial load is only marked as complete when all promises are finished (reference). A potential workaround could be to mark it as complete right before invoking the promises to avoid executing the Another enhancement would be to debounce the run to avoid invoking multiple times the |
Proposed Changes
This PR handles adding extra chat context to the API request.
Fixes: https://github.com/Automattic/dotcom-forge/issues/7601
Testing Instructions
eg: what is my wordpress version? What is my php version? What are my themes?
Pre-merge Checklist