Allow PHP version to be changed from Site Settings

src/components/content-tab-settings.tsx

@@ -1,12 +1,14 @@
 import { Icon, file } from '@wordpress/icons';
 import { useI18n } from '@wordpress/react-i18n';
 import { PropsWithChildren } from 'react';
+import { useGetPhpVersion } from '../hooks/use-get-php-version';
 import { useGetWpVersion } from '../hooks/use-get-wp-version';
 import { getIpcApi } from '../lib/get-ipc-api';
 import { decodePassword } from '../lib/passwords';
 import Button from './button';
 import { CopyTextButton } from './copy-text-button';
 import DeleteSite from './delete-site';
+import EditPhpVersion from './edit-php-version';
 import EditSite from './edit-site';
 
 interface ContentTabSettingsProps {
@@ -30,6 +32,7 @@ export function ContentTabSettings( { selectedSite }: ContentTabSettingsProps )
 	// Empty strings account for legacy sites lacking a stored password.
 	const storedPassword = decodePassword( selectedSite.adminPassword ?? '' );
 	const password = storedPassword === '' ? 'password' : storedPassword;
+	const phpVersion = useGetPhpVersion( selectedSite );
 	const wpVersion = useGetWpVersion( selectedSite );
 	return (
 		<div className="p-8">
@@ -67,6 +70,12 @@ export function ContentTabSettings( { selectedSite }: ContentTabSettingsProps )
 						</Button>
 					</SettingsRow>
 					<SettingsRow label={ __( 'WP Version' ) }>{ wpVersion }</SettingsRow>
+					<SettingsRow label={ __( 'PHP Version' ) }>
+						<div className="flex">
+							<span className="line-clamp-1 break-all">{ phpVersion }</span>
+							<EditPhpVersion />
+						</div>
+					</SettingsRow>
 
 					<tr>
 						<th colSpan={ 2 } className="pb-4 ltr:text-left rtl:text-right">

src/components/edit-php-version.tsx

@@ -0,0 +1,115 @@
+import { SelectControl } from '@wordpress/components';
+import { useI18n } from '@wordpress/react-i18n';
+import { FormEvent, useCallback, useEffect, useState } from 'react';
+import { DEFAULT_PHP_VERSION, AVAILABLE_PHP_VERSIONS } from '../constants';
+import { useSiteDetails } from '../hooks/use-site-details';
+import Button from './button';
+import Modal from './modal';
+
+export default function EditPhpVersion() {
+	const { __ } = useI18n();
+	const { updateSite, selectedSite, stopServer, startServer } = useSiteDetails();
+	const [ editPhpVersionError, setEditPhpVersionError ] = useState( '' );
+	const [ selectedPhpVersion, setSelectedPhpVersion ] = useState( DEFAULT_PHP_VERSION );
+	const [ needsToEditPhpVersion, setNeedsToEditPhpVersion ] = useState( false );
+	const [ isEditingSite, setIsEditingSite ] = useState( false );
+
+	useEffect( () => {
+		if ( selectedSite ) {
+			setSelectedPhpVersion( selectedSite.phpVersion );
+		}
+	}, [ selectedSite ] );
+
+	const resetLocalState = useCallback( () => {
+		setNeedsToEditPhpVersion( false );
+		setSelectedPhpVersion( '' );
+		setEditPhpVersionError( '' );
+	}, [] );
+
+	const onSiteEdit = useCallback(
+		async ( event: FormEvent ) => {
+			event.preventDefault();
+			if ( ! selectedSite ) {
+				return;
+			}
+			setIsEditingSite( true );
+			try {
+				const running = selectedSite.running;
+				await updateSite( {
+					...selectedSite,
+					phpVersion: selectedPhpVersion,
+				} );
+				if ( running ) {
+					await stopServer( selectedSite.id );
+					await startServer( selectedSite.id );
+				}
+				setNeedsToEditPhpVersion( false );
+				resetLocalState();
+			} catch ( e ) {
+				setEditPhpVersionError( ( e as Error )?.message );
+			}
+			setIsEditingSite( false );
+		},
+		[ updateSite, selectedSite, selectedPhpVersion, resetLocalState, startServer, stopServer ]
+	);
+
+	return (
+		<>
+			{ needsToEditPhpVersion && (
+				<Modal
+					size="medium"
+					title={ __( 'Edit PHP version' ) }
+					isDismissible
+					focusOnMount="firstContentElement"
+					onRequestClose={ resetLocalState }
+				>
+					<form onSubmit={ onSiteEdit }>
+						<label className="flex flex-col gap-1.5 leading-4">
+							<span className="font-semibold">{ __( 'PHP version' ) }</span>
+							<SelectControl
+								value={ selectedPhpVersion }
+								options={ AVAILABLE_PHP_VERSIONS.map( ( version ) => ( {
+									label: version,
+									value: version,
+								} ) ) }
+								onChange={ ( version ) => setSelectedPhpVersion( version ) }
+							/>
+						</label>
+						<div className="flex flex-row justify-end gap-x-5 mt-6">
+							<Button onClick={ resetLocalState } disabled={ isEditingSite } variant="tertiary">
+								{ __( 'Cancel' ) }
+							</Button>
+							<Button
+								type="submit"
+								variant="primary"
+								isBusy={ isEditingSite }
+								disabled={ Boolean(
+									isEditingSite ||
+										! selectedSite ||
+										selectedSite?.phpVersion === selectedPhpVersion ||
+										editPhpVersionError
+								) }
+							>
+								{ isEditingSite ? __( 'Restarting server…' ) : __( 'Save' ) }
+							</Button>
+						</div>
+					</form>
+				</Modal>
+			) }
+			<Button
+				disabled={ ! selectedSite }
+				className="!mx-4 shrink-0"
+				onClick={ () => {
+					if ( selectedSite ) {
+						setSelectedPhpVersion( selectedSite.phpVersion );
+					}
+					setNeedsToEditPhpVersion( true );
+				} }
+				label={ __( 'Edit PHP version' ) }
+				variant="link"
+			>
+				{ __( 'Edit' ) }
+			</Button>
+		</>
+	);
+}

src/components/tests/content-tab-assistant.test.tsx

@@ -10,6 +10,7 @@ const runningSite = {
 	port: 8881,
 	path: '/path/to/site',
 	running: true,
+	phpVersion: '8.0',
 	id: 'site-id',
 	url: 'http://example.com',
 };

src/components/tests/content-tab-overview-shortcuts-section.test.tsx

@@ -10,6 +10,7 @@ const selectedSite: StartedSiteDetails = {
 	port: 8881,
 	path: '/path/to/site',
 	running: true,
+	phpVersion: '8.0',
 	id: 'site-id',
 	url: 'http://example.com',
 };

src/components/tests/content-tab-overview.test.tsx

@@ -9,6 +9,7 @@ const runningSite: StartedSiteDetails = {
 	name: 'Test Site',
 	port: 8881,
 	path: '/path/to/site',
+	phpVersion: '8.0',
 	running: true,
 	id: 'site-id',
 	url: 'http://example.com',
@@ -18,6 +19,7 @@ const notRunningSite: SiteDetails = {
 	name: 'Test Site',
 	port: 8881,
 	path: '/path/to/site',
+	phpVersion: '8.0',
 	running: false,
 	id: 'site-id',
 };

src/components/tests/content-tab-settings.test.tsx

@@ -1,13 +1,15 @@
 // To run tests, execute `npm run test -- src/components/content-tab-settings.test.tsx` from the root directory
 import { fireEvent, render, screen } from '@testing-library/react';
 import { userEvent } from '@testing-library/user-event';
+import { useGetPhpVersion } from '../../hooks/use-get-php-version';
 import { useGetWpVersion } from '../../hooks/use-get-wp-version';
 import { useOffline } from '../../hooks/use-offline';
 import { useSiteDetails } from '../../hooks/use-site-details';
 import { getIpcApi } from '../../lib/get-ipc-api';
 import { ContentTabSettings } from '../content-tab-settings';
 
 jest.mock( '../../hooks/use-get-wp-version' );
+jest.mock( '../../hooks/use-get-php-version' );
 jest.mock( '../../hooks/use-site-details' );
 jest.mock( '../../lib/get-ipc-api' );
 
@@ -17,6 +19,7 @@ const selectedSite: SiteDetails = {
 	path: '/path/to/site',
 	adminPassword: btoa( 'test-password' ),
 	running: false,
+	phpVersion: '8.0',
 	id: 'site-id',
 };
 
@@ -27,6 +30,7 @@ describe( 'ContentTabSettings', () => {
 	beforeEach( () => {
 		jest.clearAllMocks();
 		( useGetWpVersion as jest.Mock ).mockReturnValue( '7.7.7' );
+		( useGetPhpVersion as jest.Mock ).mockReturnValue( '8.0' );
 		( getIpcApi as jest.Mock ).mockReturnValue( {
 			copyText,
 			openLocalPath,

src/components/tests/content-tab-snapshots.test.tsx

@@ -46,6 +46,7 @@ const selectedSite = {
 	name: 'Test Site',
 	running: false as const,
 	path: '/test-site',
+	phpVersion: '8.0',
 	adminPassword: btoa( 'test-password' ),
 };
 

src/constants.ts

@@ -20,3 +20,5 @@ export const CLIENT_ID = '95109';
 export const PROTOCOL_PREFIX = 'wpcom-local-dev';
 export const WP_AUTHORIZE_ENDPOINT = 'https://public-api.wordpress.com/oauth2/authorize';
 export const SCOPES = 'global';
+export const DEFAULT_PHP_VERSION = '8.0';
+export const AVAILABLE_PHP_VERSIONS = [ '7.4', '8.0', '8.1', '8.2' ];

src/hooks/tests/use-update-demo-site.test.tsx

@@ -40,6 +40,7 @@ describe( 'useUpdateDemoSite', () => {
 	const mockLocalSite: SiteDetails = {
 		name: 'Test Site',
 		running: false,
+		phpVersion: '8.0',
 		id: '54321',
 		path: '/path/to/site',
 	};

src/hooks/use-get-php-version.ts

@@ -0,0 +1,11 @@
+import { useEffect, useState } from 'react';
+import { DEFAULT_PHP_VERSION } from '../constants';
+import { getIpcApi } from '../lib/get-ipc-api';
+
+export function useGetPhpVersion( site: SiteDetails ) {
+	const [ phpVersion, setPhpVersion ] = useState( DEFAULT_PHP_VERSION );
+	useEffect( () => {
+		getIpcApi().getPhpVersion( site.id ).then( setPhpVersion );
+	}, [ site.id, site.running, site.phpVersion ] );
+	return phpVersion;
+}

src/ipc-handlers.ts

@@ -17,7 +17,7 @@ import { copySync } from 'fs-extra';
 import { SQLITE_FILENAME } from '../vendor/wp-now/src/constants';
 import { downloadSqliteIntegrationPlugin } from '../vendor/wp-now/src/download';
 import { executeWPCli } from '../vendor/wp-now/src/execute-wp-cli';
-import { LIMIT_ARCHIVE_SIZE } from './constants';
+import { LIMIT_ARCHIVE_SIZE, DEFAULT_PHP_VERSION } from './constants';
 import { isEmptyDir, pathExists, isWordPressDirectory, sanitizeFolderName } from './lib/fs-utils';
 import { getImageData } from './lib/get-image-data';
 import { isErrnoException } from './lib/is-errno-exception';
@@ -157,6 +157,7 @@ export async function createSite(
 		path,
 		adminPassword: createPassword(),
 		running: false,
+		phpVersion: DEFAULT_PHP_VERSION,
 	} as const;
 
 	const server = SiteServer.create( details );
@@ -464,6 +465,14 @@ export async function getAppGlobals( _event: IpcMainInvokeEvent ): Promise< AppG
 	};
 }
 
+export async function getPhpVersion( _event: IpcMainInvokeEvent, id: string ) {
+	const server = SiteServer.get( id );
+	if ( ! server ) {
+		return DEFAULT_PHP_VERSION;
+	}
+	return server.details.phpVersion || DEFAULT_PHP_VERSION;
+}
+
 export async function getWpVersion( _event: IpcMainInvokeEvent, id: string ) {
 	const server = SiteServer.get( id );
 	if ( ! server ) {

src/ipc-types.d.ts

@@ -18,6 +18,7 @@ interface StoppedSiteDetails {
 	name: string;
 	path: string;
 	port?: number;
+	phpVersion: string;
 	adminPassword?: string;
 	themeDetails?: {
 		name: string;

src/preload.ts

@@ -29,6 +29,7 @@ const api: IpcApi = {
 	copyText: ( text: string ) => ipcRenderer.invoke( 'copyText', text ),
 	getAppGlobals: () => ipcRenderer.invoke( 'getAppGlobals' ),
 	removeTemporalFile: ( path: string ) => ipcRenderer.invoke( 'removeTemporalFile', path ),
+	getPhpVersion: ( id: string ) => ipcRenderer.invoke( 'getPhpVersion', id ),
 	getWpVersion: ( id: string ) => ipcRenderer.invoke( 'getWpVersion', id ),
 	generateProposedSitePath: ( siteName: string ) =>
 		ipcRenderer.invoke( 'generateProposedSitePath', siteName ),

src/site-server.ts

@@ -4,6 +4,7 @@ import * as Sentry from '@sentry/electron/main';
 import { getWpNowConfig } from '../vendor/wp-now/src';
 import { WPNowMode } from '../vendor/wp-now/src/config';
 import { getWordPressVersionPath } from '../vendor/wp-now/src/download';
+import { DEFAULT_PHP_VERSION } from './constants';
 import { pathExists, recursiveCopyDirectory, isEmptyDir } from './lib/fs-utils';
 import { decodePassword } from './lib/passwords';
 import { phpGetThemeDetails } from './lib/php-get-theme-details';
@@ -74,6 +75,7 @@ export class SiteServer {
 			port,
 			adminPassword: decodePassword( this.details.adminPassword ?? '' ),
 			siteTitle: this.details.name,
+			php: this.details.phpVersion ?? DEFAULT_PHP_VERSION,
 		} );
 		const absoluteUrl = `http://localhost:${ port }`;
 		options.absoluteUrl = absoluteUrl;
@@ -99,6 +101,7 @@ export class SiteServer {
 			...this.details,
 			url: this.server.url,
 			port: this.server.options.port,
+			phpVersion: this.server.options.phpVersion || DEFAULT_PHP_VERSION,
 			running: true,
 			themeDetails,
 		};
@@ -109,6 +112,7 @@ export class SiteServer {
 			...this.details,
 			name: site.name,
 			path: site.path,
+			phpVersion: site.phpVersion,
 		};
 	}
 

src/storage/user-data.ts

@@ -75,7 +75,7 @@ export async function saveUserData( data: UserData ): Promise< void > {
 function toDiskFormat( { sites, ...rest }: UserData ): PersistedUserData {
 	return {
 		version: 1,
-		sites: sites.map( ( { id, path, adminPassword, port, name, themeDetails } ) => {
+		sites: sites.map( ( { id, path, adminPassword, port, phpVersion, name, themeDetails } ) => {
 			// No object spreading allowed. TypeScript's structural typing is too permissive and
 			// will permit us to persist properties that aren't in the type definition.
 			// Add each property explicitly instead.
@@ -85,6 +85,7 @@ function toDiskFormat( { sites, ...rest }: UserData ): PersistedUserData {
 				path,
 				adminPassword,
 				port,
+				phpVersion,
 				themeDetails: {
 					name: themeDetails?.name || '',
 					path: themeDetails?.path || '',

src/tests/ipc-handlers.test.ts

@@ -59,6 +59,7 @@ describe( 'createSite', () => {
 			id: expect.any( String ),
 			name: 'Test',
 			path: '/test',
+			phpVersion: '8.0',
 			running: false,
 		} );
 	} );

src/tests/site-server.test.ts

@@ -31,6 +31,7 @@ describe( 'SiteServer', () => {
 				path: 'test-path',
 				port: 1234,
 				adminPassword: 'test-password',
+				phpVersion: '8.0',
 				running: false,
 				themeDetails: undefined,
 			} );