Skip to content

Conversation

@katinthehatsite
Copy link
Contributor

@katinthehatsite katinthehatsite commented Oct 22, 2025

Related issues

Related to STU-749

Proposed Changes

This PR adds more detailed message for the user when the database import fails during the Push process, writes to logs the error and provides further direction for the user in the message:

Screenshot 2025-10-24 at 11 59 34 AM

Logs:

Screenshot 2025-10-24 at 11 57 00 AM

Testing Instructions

  • Pull the changes from this branch
  • Use a Studio site with the broken database (you can break the database by, for example, putting a wrong data_type for one of the rows in one of the database tables so that SQLite to MySQL conversion breaks)
  • Navigate to Sync tab
  • Attempt a push process to one of your WP.com sites
  • Confirm that you can see the error from the screenshot when the import fails
  • For now, I left the wording like this but we can adjust it further if it is not clear enough

Pre-merge Checklist

  • Have you checked for TypeScript, React or other console errors?

@katinthehatsite katinthehatsite self-assigned this Oct 22, 2025
@katinthehatsite katinthehatsite marked this pull request as draft October 22, 2025 14:54
@github-actions
Copy link

github-actions bot commented Oct 22, 2025

📊 Performance Test Results

Comparing 27a0743 vs trunk

site-editor

Metric trunk 27a0743 Diff Change
load 9311.00 ms 9368.00 ms +57.00 ms 🔴 0.6%

site-startup

Metric trunk 27a0743 Diff Change
siteCreation 17234.00 ms 26596.00 ms +9362.00 ms 🔴 54.3%
siteStartup 5933.00 ms 5971.00 ms +38.00 ms 🔴 0.6%

Results are median values from multiple test runs.

Legend: 🟢 Improvement (faster) | 🔴 Regression (slower) | ⚪ No change

@katinthehatsite katinthehatsite marked this pull request as ready for review October 24, 2025 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant