Skip to content

Conversation

@bcotrim
Copy link
Contributor

@bcotrim bcotrim commented Oct 9, 2025

Related issues

Proposed Changes

  • Add cancel button UI to sync operations
  • Push can be canceled during backup creation
  • Pull can be cancelled while remote backup creation and download
Cancel button Cancelled
image image

Testing Instructions

  • Start a push/pull operation from Studio to WordPress.com
  • During the sync progress, click the X icon to the right of the progress bar
  • Verify the operation cancels
  • Test cancellation at different stages of the sync process to ensure it works during safe stages
  • Confirm cancellation is disabled after safe stages

Pre-merge Checklist

  • Have you checked for TypeScript, React or other console errors?

@bcotrim bcotrim self-assigned this Oct 9, 2025
@bcotrim bcotrim marked this pull request as draft October 9, 2025 12:53
@bcotrim bcotrim force-pushed the stu-156-studio-ability-to-cancel-the-push-and-pull branch 2 times, most recently from 61b5ec7 to 0c15689 Compare October 16, 2025 22:36
@bcotrim bcotrim marked this pull request as ready for review October 16, 2025 22:38
@github-actions
Copy link

github-actions bot commented Oct 16, 2025

📊 Performance Test Results

Comparing 4b09545 vs trunk

site-editor

Metric trunk 4b09545 Diff Change
load 10605.00 ms 9370.00 ms -1235.00 ms 🟢 -11.6%

site-startup

Metric trunk 4b09545 Diff Change
siteCreation 14008.00 ms 12974.00 ms -1034.00 ms 🟢 -7.4%
siteStartup 3957.00 ms 3970.00 ms +13.00 ms 🔴 0.3%

Results are median values from multiple test runs.

Legend: 🟢 Improvement (faster) | 🔴 Regression (slower) | ⚪ No change

@bcotrim bcotrim requested a review from a team October 17, 2025 16:36
Copy link
Contributor

@katinthehatsite katinthehatsite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this PR, it is nice to have an ability to cancel sync operations ❤️

I have noticed two issue while testing:

  • If you cancel push first and then start pull and cancel it as well, you end up with a weird state:
Image

I think we need to update it to only include that text in relation to the exact operation that was cancelled.

  • Cancel pull was slightly overlapping the side of the screen for me:
Image

@bcotrim bcotrim force-pushed the stu-156-studio-ability-to-cancel-the-push-and-pull branch from 0c15689 to 99ba314 Compare October 22, 2025 08:49
Copy link
Contributor

@katinthehatsite katinthehatsite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing previous feedback 👍

The Cancel pull looks good to me now 👍

Image

I also did not spot anymore the issue with cancelling push and pull UI. Just left a couple of minor comments.

@bcotrim bcotrim merged commit 48ac99a into trunk Oct 23, 2025
12 checks passed
@bcotrim bcotrim deleted the stu-156-studio-ability-to-cancel-the-push-and-pull branch October 23, 2025 10:18
@bcotrim bcotrim mentioned this pull request Oct 23, 2025
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants