-
Couldn't load subscription status.
- Fork 51
Studio: Ability to cancel the push and pull #1864
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Studio: Ability to cancel the push and pull #1864
Conversation
61b5ec7 to
0c15689
Compare
📊 Performance Test ResultsComparing 4b09545 vs trunk site-editor
site-startup
Results are median values from multiple test runs. Legend: 🟢 Improvement (faster) | 🔴 Regression (slower) | ⚪ No change |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding this PR, it is nice to have an ability to cancel sync operations ❤️
I have noticed two issue while testing:
- If you cancel push first and then start pull and cancel it as well, you end up with a weird state:
I think we need to update it to only include that text in relation to the exact operation that was cancelled.
Cancel pullwas slightly overlapping the side of the screen for me:
0c15689 to
99ba314
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.

Related issues
Proposed Changes
Testing Instructions
Pre-merge Checklist