Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Studio: Update "Create a free account" link to redirect to magic signup flow #123

Merged
merged 2 commits into from
May 14, 2024

Conversation

SiobhyB
Copy link

@SiobhyB SiobhyB commented May 14, 2024

Fixes 5531-gh-Automattic/dotcom-forge and 5532-gh-Automattic/dotcom-forge

Proposed Changes

Testing Instructions

  • Log out of both WordPress.com and the Studio app.
  • In the Studio app, navigate to the Share tab.
  • Click on the "Create a free account" link in the Studio app.
  • Verify you're taken to the magic signup page and enter an email that's not already associated with a WordPress.com account.
  • Go through the flow to complete account setup and verify you're automatically logged into the Studio app.
Link Form

Pre-merge Checklist

  • Have you checked for TypeScript, React or other console errors?

@SiobhyB SiobhyB added the [Type] Enhancement Improvement upon an existing feature label May 14, 2024
@SiobhyB SiobhyB self-assigned this May 14, 2024
@SiobhyB SiobhyB changed the title Studio: Use magic login flow in new account URL Studio: Update "Create a free account" link to redirect to magic signup flow May 14, 2024
@SiobhyB SiobhyB marked this pull request as ready for review May 14, 2024 09:12
@SiobhyB SiobhyB requested review from a team May 14, 2024 09:12
Copy link
Contributor

@fluiddot fluiddot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎊 ! Awesome work @SiobhyB 🏅 !

I followed the testing instructions and managed to create a new WPCOM account via the magic signup flow. The last step redirected successfully to the page that prompts opening the Studio app and confirmed the new account is logged in the app.

@SiobhyB SiobhyB merged commit dfb8f8b into trunk May 14, 2024
16 of 18 checks passed
@SiobhyB SiobhyB deleted the update/account-creation-url branch May 14, 2024 10:45
Copy link

sentry-io bot commented May 18, 2024

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ Error: Can not find Squirrel t.setupUpdates(main/studio/./src/updates) View Issue
  • ‼️ Error: Failed to get 'logs' path t.setupLogging(main/studio/./src/logging) View Issue
  • ‼️ RangeError: Incorrect locale information provided t.getSupportedLocale(main/studio/./src/lib/locale) View Issue

Did you find this useful? React with a 👍 or 👎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Enhancement Improvement upon an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants