[Tooling] Remove references to App Center #1240
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
App Center has been discontinued We've replaced it with Firebase App Distribution for iOS builds, but FAD does not seem to support macOS binaries. So instead we are keeping the lane to build the app with DeveloperID signing, but will let devs decide how to distribute it for the time being. Using `build_and_upload_app_store` to upload the builds to TestFlight and use TestFlight for beta testing is now the preferred way to distribute betas. If we end up really needing to distribute separate _internal_ betas of SNMac signed with DeveloperID on a frequent-ish basis in the future, we could consider still using this `build_beta` lane and distributing them through AppsCDN; but at that point it's not a need we have anymore.
AliSoftware
changed the title
AliSoftware
added
the
tooling
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix
App Center has been discontinued, so removing all integrations of it.
(Internal reference: paaHJt-7S2-p2)
Closes https://github.com/Automattic/apps-infra-plans/issues/224
Additional details
We've replaced it with Firebase App Distribution for iOS builds in other repos, but FAD does not seem to support macOS binaries. So instead we are keeping the lane to build the app with DeveloperID signing, but will let devs decide how to distribute it for the time being.
For the time being, using
build_and_upload_app_storeto upload the builds to TestFlight and use TestFlight for internal beta testing is the preferred way to distribute betas.If there's a need to codesign the app with a DeveloperID to distribute Simplenote macOS outside the App Store (and have it be updated via Sparkle), we could consider adding support for distributing those builds through AppsCDN at some point (hence why I still kept the lane and the setup with DeveloperID signing around just in case). But since at the time of writing this we don't have such imminent need, this will not be implemented in this PR.
We can always set up an AppsCDN site for it then update the
Fastfileto useupload_build_to_apps_cdnif that need ever arise in the future.Test
*_MATCH_*secrets from~/.mobile-secretsandexportthem as env varsbundle exec fastlane build_internal_betaand verify it compiles and generates abuild/Simplenote.appsigned with DeveloperID as a result.Review
A developer and/or Apps Infra is required to review these changes
Release
These changes do not require release notes.