Fix line spacing when printing markdown note #992
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! But I'm not exactly sure what this PR is fixing/improving. The large line spacing issue isn't fixed, and I don't see why we need to add all these styles. Could you maybe clarify your intent? |
|
Intent is to adjust spacing, which I have done with additional commit. I have borrowed resets from Gutenberg: https://github.com/BafS/Gutenberg/blob/master/scss/_print-reset.scss |
|
Ok, thanks for clarifying! However, I was thinking the line spacing issue brought up in #540 is caused by the |
|
Yes, that's fixing the issue, have updated the PR. Thank you for hint :) |
mirka
approved these changes
Nov 9, 2018
mirka
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.