Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add modification timestamp to zip #826

Merged

Conversation

ianmorti
Copy link
Contributor

@ianmorti ianmorti commented Sep 5, 2018

grab the modification date from the note and use it in the options
for JSZip so the zip file accurately reflects the note ordering

  grab the modification date from the note and use it in the options
  for JSZip so the zip file accurately reflects the note ordering
@mirka mirka added enhancement Improve existing functionality OSS Citizen labels Sep 5, 2018
@mirka mirka self-requested a review September 5, 2018 21:14
Copy link
Member

@mirka mirka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a great enhancement! I love it. Thank you @ianmorti

lib/utils/export/to-zip.js Outdated Show resolved Hide resolved
@mirka
Copy link
Member

mirka commented Sep 6, 2018

Perfect! Thank you 🙂

@mirka mirka merged commit df84cd1 into Automattic:master Sep 6, 2018
@ianmorti
Copy link
Contributor Author

ianmorti commented Sep 6, 2018

thanks !

I think this might also help out @marianoju with #271

@marianoju
Copy link

Nice. Definitely a functional enhancement! 👍

image

However this does not satisfy the motivation behind my comment on #271:

Downloading a .zip archive from the web app at https://app.simplenote.com is not an option for me [...] since client failed to synchronize data was not accessible trough the web app; [...]

An export function within the Simplenote app would have been required to back-up notes to local textfiles (as asked for in #319). I have not experienced problems with synchronization since #332.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improve existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants