Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Redux Devtools enhancer to store to make extension function #1918

Merged
merged 3 commits into from
Feb 20, 2020

Conversation

belcherj
Copy link
Contributor

Fix

Chrome Extension: https://chrome.google.com/webstore/detail/redux-devtools/lmhkpmbekcpmknklioeibfkpmmfibljd

https://github.com/zalmoxisus/redux-devtools-extension#usage

Before:
Screen Shot 2020-02-20 at 10 01 57 AM

After:
Screen Shot 2020-02-20 at 10 01 26 AM

Test

  1. Install Redux Devtools Extension
  2. Open Devtools
  3. Observe you can use it

@belcherj belcherj requested a review from a team February 20, 2020 15:04
@belcherj belcherj self-assigned this Feb 20, 2020
Copy link
Member

@codebykat codebykat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh heck yeah! Tested in Firefox - it works like a dream.

Copy link
Member

@codebykat codebykat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh dang, belay that -- it breaks Electron. Do we need an isElectron check?

redux.js?7276:600 Uncaught TypeError: Cannot read property 'apply' of undefined
    at eval (redux.js?7276:600)
    at createStore (redux.js?7276:79)
    at eval (index.ts?8bce:59)
    at Module../state/index.ts (app.800fd881e03c1b45b33d.js:14147)
    at __webpack_require__ (app.800fd881e03c1b45b33d.js:770)
    at fn (app.800fd881e03c1b45b33d.js:130)
    at eval (boot.ts:395)
    at Module../boot.ts (app.800fd881e03c1b45b33d.js:13201)
    at __webpack_require__ (app.800fd881e03c1b45b33d.js:770)
    at fn (app.800fd881e03c1b45b33d.js:130)

@belcherj
Copy link
Contributor Author

🤦‍♂ https://github.com/zalmoxisus/redux-devtools-extension#12-advanced-store-setup

This should be fixed now.

Copy link
Member

@codebykat codebykat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed fixed!

@belcherj belcherj merged commit fc58344 into develop Feb 20, 2020
@belcherj belcherj deleted the add/redux-devtools branch February 20, 2020 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants