-
Notifications
You must be signed in to change notification settings - Fork 559
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Redux Devtools enhancer to store to make extension function #1918
Conversation
6b2bcd2
to
79aaacc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh heck yeah! Tested in Firefox - it works like a dream.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh dang, belay that -- it breaks Electron. Do we need an isElectron check?
redux.js?7276:600 Uncaught TypeError: Cannot read property 'apply' of undefined
at eval (redux.js?7276:600)
at createStore (redux.js?7276:79)
at eval (index.ts?8bce:59)
at Module../state/index.ts (app.800fd881e03c1b45b33d.js:14147)
at __webpack_require__ (app.800fd881e03c1b45b33d.js:770)
at fn (app.800fd881e03c1b45b33d.js:130)
at eval (boot.ts:395)
at Module../boot.ts (app.800fd881e03c1b45b33d.js:13201)
at __webpack_require__ (app.800fd881e03c1b45b33d.js:770)
at fn (app.800fd881e03c1b45b33d.js:130)
🤦♂ https://github.com/zalmoxisus/redux-devtools-extension#12-advanced-store-setup This should be fixed now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Confirmed fixed!
Fix
Chrome Extension: https://chrome.google.com/webstore/detail/redux-devtools/lmhkpmbekcpmknklioeibfkpmmfibljd
https://github.com/zalmoxisus/redux-devtools-extension#usage
Before:
After:
Test