Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates dependencies #1738

Merged
merged 2 commits into from
Nov 25, 2019
Merged

Updates dependencies #1738

merged 2 commits into from
Nov 25, 2019

Conversation

belcherj
Copy link
Contributor

@belcherj belcherj commented Nov 22, 2019 •
edited
Loading

Fix

Updates dependencies to the latest.

Test

  1. Soo many changes to deps, click around the app to see if anything breaks.

Review

Only one developer is required to review these changes, but anyone can perform the review.

Release

RELEASE-NOTES.txt was updated with:

  • Updated dependencies #1738

@belcherj belcherj self-assigned this Nov 22, 2019
dmsnell
dmsnell approved these changes Nov 24, 2019
View reviewed changes
Copy link
Member

@dmsnell dmsnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reviewed the release notes for several of the package updates that looked important and nothing stood out. Ran npm test and everything passed. Built the app and smoke-tested and it looked fine.

@belcherj belcherj merged commit 188fb77 into develop Nov 25, 2019
@belcherj belcherj deleted the update/dependencies branch November 25, 2019 17:00
@codebykat codebykat added this to the 1.13 milestone Dec 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmsnell dmsnell dmsnell approved these changes

@codebykat codebykat Awaiting requested review from codebykat

Assignees

@belcherj belcherj

Labels
None yet
Projects
None yet
Milestone
1.13
Development

Successfully merging this pull request may close these issues.
3 participants
@belcherj @dmsnell @codebykat