-
Notifications
You must be signed in to change notification settings - Fork 559
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add script to deploy web app #1723
Conversation
Losing GitHUb Actions we made the call to make deployment local rather than adding another level of CI
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In a follow-up PR we can add instructions in the README if you want to get this merged, otherwise might be handy to do now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typo aside, this seems to work. It did spit out this, which makes me wonder if some of the paths are broken:
Switched to a new branch 'webapp-staging'
rm: "." and ".." may not be removed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay I'm not immediately seeing why but this script deletes my config-local.json
.
touch .gitignore | ||
echo config-local.json >> .gitignore | ||
git add --all | ||
git commit -m "Build: $COMMIT_BRANCH [ci skip]" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if we're wanting to deploy a given branch why are we building this and making a commit to that branch?
do we not have a way to inject a different config for the different environments?
seems like we ought to be able to do it like this…
git checkout webapp-develop
git reset --hard develop
Does something in the build process push itself out to VIP Go?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When the head of the webapp, webapp-staging, and webapp-develop branches change VIP Go grabs the contents of the repo and pushes it to the server.
We do not have a way to inject a different config for the different environments.
I am not sure what the code suggestion achieves.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the code suggestion would change the HEAD
of those branches and should trigger web hooks to fire. the branches effectively would work like tags.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
VIP Go doesn't build the app it only grabs what's in the folder. https://github.com/Automattic/simplenote-electron/tree/webapp
Fix
Losing GitHub Actions we made the call to make deployment local rather than
adding another level of CI
Test
npm run deploy staging
Review
Only one developer is required to review these changes, but anyone can perform the review.
Release