Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renames CHANGELOG.md to match Hogwarts process #1576

Merged
merged 2 commits into from
Sep 24, 2019

Conversation

belcherj
Copy link
Contributor

Fix

Renames CHANGELOG.md to RELEASE-NOTES.txt to match Hogwarts process

Test

No testing needed

Review

Only one developer is required to review these changes, but anyone can perform the review.

Release

RELEASE-NOTES.txt was updated in with:

Renamed CHANGELOG.md to RELEASE-NOTES.txt

Copy link
Member

@codebykat codebykat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs a rebase now but 👍

@belcherj belcherj added this to the 1.10 milestone Sep 24, 2019
@belcherj belcherj force-pushed the fix/rename-changelog-for-hogwarts-process branch from b3bce96 to 5a2271d Compare September 24, 2019 13:17
@belcherj belcherj merged commit 1e16362 into develop Sep 24, 2019
@loremattei loremattei modified the milestones: 1.10, 1.9 Oct 7, 2019
@belcherj belcherj deleted the fix/rename-changelog-for-hogwarts-process branch October 18, 2019 13:41
dmsnell added a commit that referenced this pull request Apr 20, 2020
In #1576 we renamed `CHANGELOG.md` to `RELEASE-NOTES.txt` and in so doing we broke any integration which attempted to render the contents of the file as Markdown. The file continued to be written as a Markdown document but by renaming the extension we prevented any tools which rely on the extension to detect the type and so valuable tools like GitHub's diff viewer wouldn't show the contents of the file as they were written but instead as if they were plain text.

In this patch we're renaming it back to a `.md` extension to reflect the reality of the file that it is indeed Markdown content. In so doing we're fixing the integrations that were broken in #1576.
codebykat added a commit that referenced this pull request Apr 23, 2020
* 1.16 release notes

* Rename RELEASE-NOTES.txt to RELEASE-NOTES.md

In #1576 we renamed `CHANGELOG.md` to `RELEASE-NOTES.txt` and in so doing we broke any integration which attempted to render the contents of the file as Markdown. The file continued to be written as a Markdown document but by renaming the extension we prevented any tools which rely on the extension to detect the type and so valuable tools like GitHub's diff viewer wouldn't show the contents of the file as they were written but instead as if they were plain text.

In this patch we're renaming it back to a `.md` extension to reflect the reality of the file that it is indeed Markdown content. In so doing we're fixing the integrations that were broken in #1576.

* typo fixes

Co-authored-by: Dennis Snell <dennis.snell@automattic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants