Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependency eslint-config-prettier to v6 #1408

Merged
merged 1 commit into from
Jul 2, 2019

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Jun 25, 2019

This PR contains the following updates:

Package Type Update Change
eslint-config-prettier devDependencies major 4.3.0 -> 6.0.0

Release Notes

prettier/eslint-config-prettier

v6.0.0

Compare Source

  • Changed: The CLI helper tool now considers [no-confusing-arrow] to conflict
    if you use the default value of its allowParens option. The default was
    changed to true in ESLint 6, which conflicts with Prettier.

    If the CLI helper tool gives you errors about this after upgrading, the
    solution is to change this:

    {
      "rules": {
        "no-confusing-arrow": ["error"]
      }
    }

    Into this:

    {
      "rules": {
        "no-confusing-arrow": ["error", { "allowParens": false }]
      }
    }

    The latter works in both ESLint 6 as well as in ESLint 5 and older.

  • Improved: eslint --print-config usage instructions. The CLI tool help
    text as well as the documentation has been updated to suggest commands that
    work in ESLint 6.0 as well as in ESLint 5 and older. (Instead of eslint --print-config ., use eslint --print-config path/to/main.js.)

v5.1.0

Compare Source

  • Added: [react/jsx-curly-newline]. Thanks to Masafumi Koba (@​ybiquitous)!

v5.0.0

Compare Source

  • Removed: [react/self-closing-comp]. This rule was added in v4.1.0 not
    because it conflicted with Prettier but because it was unnecessary when
    using Prettier. However, in v1.18.0 [Prettier stopped converting empty
    elements to self-closing elements][prettier-self-closing]. So the rule is
    not unnecessary anymore.

    If you use Prettier v1.17.1 or older you should be able to upgrade
    eslint-config-prettier to v5.0.0 without having to do anything else.

    If you use Prettier v1.18.0 or newer, you might get lint errors about for
    example changing <div></div> into <div />. You have two options:

    • Run eslint --fix if you prefer to enforce self-closing elements where
      possible. This should fix all the errors.
    • Add "react/self-closing-comp": "off" to your ESLint config if you use
      autofix from your editor and you face the same [issue as Prettier
      did][prettier-self-closing].
  • Changed: Node.js 6 is no longer officially supported, but v5.0.0 should
    still work with it.


Renovate configuration

📅 Schedule: At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻️ Rebasing: Whenever PR becomes conflicted, or if you modify the PR title to begin with "rebase!".

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot. View repository job log here.

Copy link
Contributor

@belcherj belcherj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed and Tested

@belcherj belcherj merged commit bec699a into develop Jul 2, 2019
@belcherj belcherj deleted the renovate/eslint-config-prettier-6.x branch July 2, 2019 17:50
belcherj pushed a commit that referenced this pull request Aug 12, 2019
* Aria Label (#1400)

* Added aria label for search field

* Update dependency react-transition-group to v4.2.0 (#1421)

* Update dependency concurrently to v4.1.1 (#1409)

* Update dependency @material-ui/core to v4.1.3 (#1381)

* Update dependency focus-visible to v5 (#1382)

* Update dependency babel-eslint to v10.0.2 (#1388)

* Update dependency eslint-config-prettier to v6 (#1408)

* Update dependency eslint-plugin-react to v7.14.2 (#1406)

* Update dependency eslint-plugin-jest to v22.7.1 (#1392)

* Update dependency webpack-cli to v3.3.5 (#1405)

* Fixes linting error (#1427)

* Update dependency babel-plugin-dynamic-import-node to v2.3.0 (#1390)

* Update dependency core-js to v3.1.4 (#1386)

* Add check for local config over deve config (#1422)

* Add deploy script and vip assets (#1429)

* Update dependency lodash to v4.17.13 [SECURITY] (#1444)

* Update dependency draft-js to v0.11.0 (#1443)

* Update dependency redux to v4.0.4 (#1441)

* Pin dependencies (#1445)

* added styles for both light and dark theme to highlight note and change colors for accessibility (#1402)

* Fix the develop build

* Remove simperium link from about page (#1450)

* Updates dark mode note list styling (#1452)

* Updates dark mode note list styling

* Switch blue background to grey for dark mode

* Update version for 1.7.0-beta1

* Fixes public path for electron

* Bump version to 1.7.0-beta2

* Bump version to 1.7.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants