Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix linting warning in lib/auth/index #1311

Merged
merged 1 commit into from
Jun 10, 2019
Merged

Fix linting warning in lib/auth/index #1311

merged 1 commit into from
Jun 10, 2019

Conversation

belcherj
Copy link
Contributor

@belcherj belcherj commented Jun 4, 2019

Fix

Updates propTypes to include all props.

Test

  1. Log out
  2. Log back in
  3. Observe no errors in console

Review

Only one developer is required to review these changes, but anyone can perform the review.

@belcherj belcherj self-assigned this Jun 4, 2019
@belcherj
Copy link
Contributor Author

belcherj commented Jun 4, 2019

#1315

@belcherj belcherj requested a review from mirka June 6, 2019 15:29
@belcherj belcherj merged commit 49d1bbb into master Jun 10, 2019
@bummytime bummytime added this to the 1.6.0 ❄️ milestone Jun 17, 2019
@belcherj belcherj deleted the fix/linting-lib/auth/index branch October 18, 2019 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mirka mirka mirka approved these changes

Assignees

@belcherj belcherj

Labels
None yet
Projects
None yet
Milestone
1.6.0
Development

Successfully merging this pull request may close these issues.
3 participants
@belcherj @mirka @bummytime