Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve search performance on long notes #1218

Merged
merged 4 commits into from
Feb 28, 2019
Merged

Improve search performance on long notes #1218

merged 4 commits into from
Feb 28, 2019

Conversation

mirka
Copy link
Member

@mirka mirka commented Feb 22, 2019

Closes #1107

@mirka mirka mentioned this pull request Feb 22, 2019
Merged
roundhill
roundhill reviewed Feb 27, 2019
View reviewed changes
Copy link
Contributor

@roundhill roundhill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we have it not use the debounce when you:

  • Press escape
  • Click the X

I think it'd be a nicer UX to not have the delay there.

@mirka
Copy link
Member Author

mirka commented Feb 28, 2019

@roundhill Agreed 💯 Thanks!

@mirka mirka merged commit 59c3aff into master Feb 28, 2019
@mirka mirka deleted the enhance/search-performance branch February 28, 2019 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roundhill roundhill roundhill left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mirka @roundhill