Verify last used monitor availability when restoring window position #1176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mirka
changed the title
roundhill
approved these changes
Jan 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #592
electron-window-state(the module we are using to persist window position after quit) had not been checking whether a last used external monitor had been disconnected. So if Simplenote was last positioned on an external monitor that is now disconnected, the Simplenote window would be unrecoverable.To test
I tested this on an actual Windows machine, since I couldn't reproduce the original issue on a Mac.
Note: To reproduce the original issue, your external display must be configured to be on the LEFT of your main display.
The app window should be visible on the main screen.