Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make tag entry and removal smoother #1000

Merged
merged 1 commit into from
Nov 20, 2018
Merged

Make tag entry and removal smoother #1000

merged 1 commit into from
Nov 20, 2018

Conversation

mirka
Copy link
Member

@mirka mirka commented Nov 9, 2018

Adding and removing tags was not a smooth experience because the cursor went away after removing a tag with Backspace.

This fixes the problem, so that we can smoothly remove and add multiple tags without re-clicking the entry field.

Before

tags-before

After

tags-after

@mirka mirka requested a review from roundhill November 9, 2018 17:50
Copy link
Contributor

@roundhill roundhill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wonderful usability fix!

@roundhill
Copy link
Contributor

And congrats on #1000! 🎉

@mirka mirka merged commit ed700c5 into master Nov 20, 2018
@mirka mirka deleted the fix/tag-input-focus branch November 20, 2018 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants