Skip to content

Conversation

@theck13
Copy link
Contributor

@theck13 theck13 commented Feb 27, 2020

Fix

Add the two items to the gradle.properties file so that the email and password fields will be automatically populated for debug builds. If the loginEmail and loginPassword items are set in gradle.properties, they will be inserted into the fields for the login flow. Otherwise, the fields will be empty.

Test

  1. Clear app data.
  2. Tap Sign Up button.
  3. Notice Email and Password fields are empty.
  4. Tap back arrow in app bar.
  5. Tap Log In button.
  6. Tap Log In with Email button.
  7. Notice Email and Password fields are populated with loginEmail and loginPassword values from gradle.properties.

Review

Only one developer is required to review these changes, but anyone can perform the review.

Release

These changes do not require release notes.

@theck13 theck13 added [status] needs code review task This issue is some sort of task or a spike of time not directly related to a feature. labels Feb 27, 2020
@theck13 theck13 added this to the 2.5 milestone Feb 27, 2020
@peril-automattic
Copy link

You can test the changes on this Pull Request by downloading the APK here.

Copy link
Contributor

@anitaa1990 anitaa1990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! :shipit:

@anitaa1990 anitaa1990 merged commit f366c9c into develop Mar 5, 2020
@anitaa1990 anitaa1990 self-assigned this Mar 5, 2020
@anitaa1990 anitaa1990 deleted the add-debug-credentials branch March 5, 2020 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

task This issue is some sort of task or a spike of time not directly related to a feature.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants