Skip to content

Conversation

richardlhr
Copy link

Resolves #

Proposed Changes

  • Allow to change the Heading type (H1, H2,... H6) as having a hardcoded H2 Heading in the Header is not ADA compliant

Testing Instructions

  1. In the Admin UI, navigate to Sensei LMS > Settings > Appearance
  2. Click on the Customize Button of the Default Learning Mode Template
  3. Click on Sensei LMS Templates and then click on the Lesson Template
  4. In the Header, select the Course Title Block
  5. You should be able to see a "Change Level" setting defaulting to H2. Select H1
  6. On the Right hand side, it is not possible to also change Typography, Dimensions and add additional CSS class (Advanced) as to match the Course Progress Counter Block
  7. Save
  8. On the frontend, go to a course, navigate to the lesson and check the the Course Title has the correct tag and style.

New/Updated Hooks

  • N/A

Deprecated Code

  • N/A

Pre-Merge Checklist

  • [ X] PR title and description contain sufficient detail and accurately describe the changes
  • [ X] Adheres to coding standards (PHP, JavaScript, CSS, HTML)
  • [ X] All strings are translatable (without concatenation, handles plurals)
  • [ X] Follows our naming conventions (P6rkRX-4oA-p2)
  • Hooks (p6rkRX-1uS-p2) and functions are documented
  • [X ] New UIs are responsive and use a mobile-first approach
  • [ Xa] Code is tested on the minimum supported PHP and WordPress versions

@donnapep
Copy link
Collaborator

Hello, and thanks for the PR! I took this for a quick test drive and here's what I found:

  • Right now the text is editable but shouldn't be. Even if you try adding custom text, it's overridden when you change the level or view it on the frontend.
  • Also, would you kindly clarify what you mean by the following. Did you mean to say that it is possible to change these things?

On the Right hand side, it is not possible to also change Typography, Dimensions and add additional CSS class (Advanced) as to match the Course Progress Counter Block

🥂

Significance: patch
Type: development

Adding missing fucntionalities to Course Title Block
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Adding missing fucntionalities to Course Title Block
Add heading level selection to Course Title block

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants