Set node version to 24 - #407
Conversation
pkevan
left a comment
There was a problem hiding this comment.
Good — this completes the migration rather than starting one. e2e-tests.yml was the last workflow still on 22; release, integration, unit, static-checks and create-release-pr are all on 24 already, so this brings the outlier in line and the new .nvmrc matches.
One thing worth a look before merge: the lockfile loses six libc annotations, all on @rolldown/binding-linux-{arm64,ppc64,s390x,x64}-{gnu,musl} — exactly the packages where that field disambiguates a glibc build from a musl one. It lets npm skip the incompatible variant rather than attempting the wrong binary.
That field is emitted by npm 11, which is what Node 24 ships and what this same workflow pins one step later (npm install -g npm@11). So the lockfile appears to have been regenerated with an older npm, which is the opposite of the direction this PR is moving. Harmless on the glibc GitHub runners, but it means the committed lockfile no longer matches what CI's own npm would produce, and a future install could churn those lines back. Regenerating with npm 11 should restore them.
Also note the branch is four commits behind trunk, so the version diff in package-lock.json is just lag rather than a change — a rebase will make the diff read cleanly.
|
Updating to 24 used to fail — see #67, where the My question is the |
Summary
package-lock.jsonwith Node.js 24 and npm 11.Testing
npm installshould be sufficient