Skip to content

Conversation

@dkoo
Copy link
Contributor

@dkoo dkoo commented Feb 1, 2024

All Submissions:

Changes proposed in this Pull Request:

  1. Adds a new epic/* release workflow for creating release builds that we can use for beta testing and other QA purposes. This workflow is similar to alpha and hotfix/* workflows, but kind of in between them.
  2. Renames the master branch to trunk.

How to test the changes in this Pull Request:

Follow testing instructions in Automattic/newspack-plugin#2895, but for this repo.

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@dkoo dkoo self-assigned this Feb 1, 2024
@dkoo dkoo requested a review from a team as a code owner February 1, 2024 18:16
@dkoo dkoo changed the base branch from master to trunk February 1, 2024 18:16
Copy link
Contributor

@chickenn00dle chickenn00dle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works as expected!

Found another case of master to be updated in the codebase though:

echo '<p>The Republication sharing widget on this post is programatically disabled through the <code>hide_republication_widget</code> filter. <a href="/Automattic/republication-tracker-tool/blob/master/docs/removing-republish-button-from-categories.md" target="_blank">Read more about this filter</a>.</p>';

Gonna also give this a thumbs up.

Another aside, I created and pushed an epic branch not based on your PR branch initially and want to delete it but it is protected. Any advice on how to do that 😅

@dkoo dkoo merged commit 60185ec into trunk Feb 2, 2024
@dkoo dkoo deleted the feat/epic-release-workflow branch February 2, 2024 01:16
@dkoo
Copy link
Contributor Author

dkoo commented Feb 2, 2024

Another aside, I created and pushed an epic branch not based on your PR branch initially and want to delete it but it is protected. Any advice on how to do that 😅

Whoops, I forgot to enable branch deletion for the epics. We should now be able to delete those branches.

@matticbot
Copy link
Contributor

🎉 This PR is included in version 1.6.0-alpha.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

matticbot pushed a commit that referenced this pull request Feb 8, 2024
# [1.6.0-alpha.1](v1.5.0...v1.6.0-alpha.1) (2024-02-08)

### Features

* **ci:** add epic/* release workflow and rename `master` to `trunk` ([#199](#199)) ([60185ec](60185ec))
matticbot pushed a commit that referenced this pull request Apr 8, 2024
# [1.6.0](v1.5.0...v1.6.0) (2024-04-08)

### Features

* **ci:** add epic/* release workflow and rename `master` to `trunk` ([#199](#199)) ([60185ec](60185ec))
@matticbot
Copy link
Contributor

🎉 This PR is included in version 1.6.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants