Throw surface errors in toBuffer #2410
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
chearon
reviewed
Sep 27, 2024
mcfedr
force-pushed
the
check-errors
branch
from
1607baa
to
9c45d2f
Compare
Yes, hopefully it isnt possible to do in normal usage, but getting an file with just a PDF header and nothing else was very confusing when it happened! |
chearon
approved these changes
Sep 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed this when developing #2405
we can check cairo_surface_status for errors, which I've noticed happening when I was making tags incorrectly, but thought this is actually quite helpful, as overwise you just get en empty buffer, and have no idea why it happened.