Skip to content

add test demonstrating drawImage reflection bug #1335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 21, 2018
Merged

add test demonstrating drawImage reflection bug #1335

merged 1 commit into from
Dec 21, 2018

Conversation

bennlich
Copy link
Contributor

screenshot from 2018-12-20 15-47-43

Maybe related to #1249 ?

This seems to occur when you use context.drawImage with a source image size that is less than the destination size.

@bennlich bennlich mentioned this pull request Dec 21, 2018
Closed
@asturur
Copy link
Contributor

asturur commented Dec 21, 2018

i think my open pr would fix that. i ll try and in case finish it.

zbjornson
zbjornson approved these changes Dec 21, 2018
View reviewed changes
Copy link
Collaborator

@zbjornson zbjornson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@zbjornson zbjornson merged commit af13f8f into Automattic:master Dec 21, 2018
@bennlich bennlich deleted the draw-image-mirror-bug branch December 22, 2018 02:28
@bennlich
Copy link
Contributor Author

Woo! Y'all are so speedy!

@asturur asturur mentioned this pull request Dec 22, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zbjornson zbjornson zbjornson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bennlich @asturur @zbjornson