chore: deprecate circleci #2621
Conversation
miguelpeixe
added
the
[Status] Needs Review
.github/workflows/release.yml
Outdated
| - name: Publish child themes releases | ||
| run: node scripts/create-child-releases.js --run | ||
| env: | ||
| GH_TOKEN: ${{ secrets.GITHUB_TOKEN }} |
There was a problem hiding this comment.
In scripts/create-child-releases.js the script creates releases in the separate child-theme repos (e.g. newspack-joseph-theme). The default GITHUB_TOKEN is repo-scoped to newspack-theme, so it won't have permission to create releases in those external repos.
We might need to pass a token with access to the child-theme repos instead of secrets.GITHUB_TOKEN.
There was a problem hiding this comment.
GITHUB_TOKEN is automatically passed by gh actions, no need to be declared explicitly
There was a problem hiding this comment.
To clarify, this is about this token's permission to actually create the release in the child themes' standalone repos.
There was a problem hiding this comment.
You're right! I refactored the strategy to avoid having to manage a PAT.
Release repos will now rely on .github/workflows/reusable-sync-release.yml to create their releases. This has been applied to all repos. See https://github.com/Automattic/newspack-sacha-theme/actions for an example
# [2.18.0-hotfix-test-gh-action.1](v2.17.0...v2.18.0-hotfix-test-gh-action.1) (2026-01-28) ### Features * test gh release action ([3a37d43](3a37d43))
|
🎉 This PR is included in version 2.18.0-hotfix-test-gh-action.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
- Replaced the child release script with a reusable workflow for syncing releases. - Updated the release configuration to define themes directly in the .releaserc.js file. - Removed the deprecated publish-child-releases job from the GitHub Actions workflow.
- Updated the workflow to fetch the latest release, including pre-releases. - Added logic to conditionally create a pre-release based on the fetched release information. - Improved body fetching for releases to ensure accurate content retrieval.
# [2.18.0-hotfix-test-gh-action.2](v2.18.0-hotfix-test-gh-action.1...v2.18.0-hotfix-test-gh-action.2) (2026-01-28) ### Bug Fixes * enhance release workflow to handle pre-releases ([23c06f3](23c06f3))
This reverts commit 538f393.
This reverts commit 716b3c5.
github-actions
bot
added
[Status] Approved
|
Hey @miguelpeixe, good job getting this PR merged! 🎉 Now, the Please check if this PR needs to be included in the "Upcoming Changes" and "Release Notes" doc. If it doesn't, simply remove the label. If it does, please add an entry to our shared document, with screenshots and testing instructions if applicable, then remove the label. Thank you! ❤️ |
Same as Automattic/newspack-plugin#4413
The
build_distributableworkflow was modified to generate artifacts for each child theme. Check this run to confirm the packages are correctly generated and uploaded:https://github.com/Automattic/newspack-theme/actions/runs/21412152840