Skip to content

Conversation

@laurelfulford
Copy link
Contributor

All Submissions:

Changes proposed in this Pull Request:

See Automattic/newspack-plugin#4409

Closes # .

How to test the changes in this Pull Request:

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@laurelfulford laurelfulford marked this pull request as ready for review January 21, 2026 00:38
@laurelfulford laurelfulford requested a review from a team as a code owner January 21, 2026 00:38
@laurelfulford laurelfulford added the [Status] Needs Review The issue or pull request needs to be reviewed label Jan 21, 2026
@laurelfulford laurelfulford requested a review from Copilot January 21, 2026 00:38
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR moves My Account button styles from the Newspack Plugin to the Newspack Theme by creating a new plugin-specific stylesheet. This change supports better separation of concerns, allowing theme-specific styling to be managed within the theme itself.

Changes:

  • Added a new stylesheet for Newspack Plugin styles in the theme
  • Imported the new stylesheet into the base style file

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
sass/style-base.scss Added import for new newspack-plugin stylesheet
sass/plugins/newspack-plugin.scss Created new file containing My Account button styles

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Member

@rbcorrales rbcorrales left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving, but I think it's worth addressing the indentation issues flagged by Copilot here.

@github-actions github-actions bot added [Status] Approved The pull request has been reviewed and is ready to merge and removed [Status] Needs Review The issue or pull request needs to be reviewed labels Jan 26, 2026
@laurelfulford laurelfulford merged commit 537de07 into trunk Jan 29, 2026
11 of 12 checks passed
@laurelfulford laurelfulford deleted the feat/add-my-account-block branch January 29, 2026 18:46
@github-actions
Copy link

Hey @laurelfulford, good job getting this PR merged! 🎉

Now, the needs-changelog label has been added to it.

Please check if this PR needs to be included in the "Upcoming Changes" and "Release Notes" doc. If it doesn't, simply remove the label.

If it does, please add an entry to our shared document, with screenshots and testing instructions if applicable, then remove the label.

Thank you! ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-changelog [Status] Approved The pull request has been reviewed and is ready to merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants