feat: filter JS and print styles enqueuing #2207
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adekbadek
added
the
[Status] Needs Review
leogermani
reviewed
Nov 24, 2023
| } | ||
|
|
||
| if ( ! apply_filters( 'newspack_theme_enqueue_js', true ) ) { | ||
| return; |
Contributor
There was a problem hiding this comment.
There are some styles being loaded down below. See lines 471 and 475. Maybe they should be moved?
leogermani
approved these changes
Nov 27, 2023
github-actions
bot
added
[Status] Approved
leogermani
requested changes
Nov 27, 2023
Contributor
leogermani
left a comment
leogermani
left a comment
There was a problem hiding this comment.
actually we should also add docblocks here
6 tasks
dkoo
approved these changes
Nov 30, 2023
matticbot
pushed a commit
that referenced
this pull request
Dec 1, 2023
# [1.82.0-alpha.1](v1.81.0...v1.82.0-alpha.1) (2023-12-01) ### Features * filter JS and print styles enqueuing ([#2207](#2207)) ([86d60bf](86d60bf))
Contributor
|
🎉 This PR is included in version 1.82.0-alpha.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
matticbot
pushed a commit
that referenced
this pull request
Dec 11, 2023
# [1.82.0](v1.81.0...v1.82.0) (2023-12-11) ### Features * filter JS and print styles enqueuing ([#2207](#2207)) ([86d60bf](86d60bf))
Contributor
|
🎉 This PR is included in version 1.82.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All Submissions:
Changes proposed in this Pull Request:
Adds filters for dequeuing print styles and JS scripts.
How to test the changes in this Pull Request:
Load a page, observe that print styles (
print.css) and JS scripts (e.g.amp-fallback.js) are loaded as expectedOther information: