Skip to content

fix: skip redirect from login modal #4450

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jason10lee wants to merge 3 commits into
base: trunk
Choose a base branch
from
+7 −1
Open

fix: skip redirect from login modal #4450

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
83185d4
fix: skip redirect from login modal
jason10lee Feb 3, 2026
b8b3bf0
fix: implement Copilot suggestion
jason10lee Feb 3, 2026
0da455f
fix: check that works on an on-page block
jason10lee Feb 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion src/reader-activation-auth/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,10 @@ window.newspackRAS.push( readerActivation => {
ev.preventDefault();
const modalTrigger = ev.target;
let callback, redirect;

// Check ancestors to see if we're signing in to an existing account.
const isExistingAccountFlow = Boolean( modalTrigger.closest( '.newspack-registration__have-account' ) );

if ( ev.target.getAttribute( 'data-redirect' ) ) {
redirect = ev.target.getAttribute( 'data-redirect' );
} else {
Expand All @@ -62,7 +66,9 @@ window.newspackRAS.push( readerActivation => {
}
}
}
if ( redirect && redirect !== '#' ) {

// If we're in a modal, ignore redirect so 'Continue' dismisses it and reader can continue on the current page.
if ( redirect && redirect !== '#' && ! isExistingAccountFlow ) {
callback = () => {
window.location.href = redirect;
};
Expand Down
Loading