fix: copy over functions from teams to reconnect expired subscriptions#4367
Draft
laurelfulford wants to merge 1 commit intotrunkfrom
Draft
fix: copy over functions from teams to reconnect expired subscriptions#4367laurelfulford wants to merge 1 commit intotrunkfrom
laurelfulford wants to merge 1 commit intotrunkfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All Submissions:
Changes proposed in this Pull Request:
The Newspack Plugin has an option to move On Hold subscriptions to Expired after a customizable period of time.
For publishers using Memberships for Teams, this causes an odd problem: the Teams plugin will 'deactivate' Teams when their associated Membership Subscription is cancelled/pending cancellation/expired. When the subscription is renewed, Teams will reattach the Team using a function called
update_team_subscription_on_resubscribe(), but only in the first two cases (if the subscription is cancelled or pending cancellation). If it's expired, it does not.Closes # .
How to test the changes in this Pull Request:
Other information: