fix(autocomplete-orders): apply option to variations, not parent product #3958
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the product being checked is a variation, check the
newspack_autocomplete_ordersmeta value for the parent item, not the variation.All Submissions:
Changes proposed in this Pull Request:
#3072 added a custom product option to allow autocompletion of orders with that product. #3111 restricted this option to usage with "virtual" products, while #3692 rescinded that requirement based on publisher feedback, but didn't remove the wrapper classes that hid the option from non-virtual products and variations, creating confusion and making it impossible to properly set the option value on non-virtual products.
This PR clarifies the usage of the option by adding a new
product_typesconfig key to custom options, so that the options will only be shown and filters applied for products that match the supported types.How to test the changes in this Pull Request:
Other information: